Skip to content

Conversation

tom-un
Copy link
Collaborator

@tom-un tom-un commented Sep 5, 2019

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Description of changes

The previous Pull Request #146 renamed and moved the Flow type NativeOrDynamicColorType. It also created some circular references via the import type imports of this type. Flow itself seems to be able to handle these circular references, but an internal tool in Microsoft cannot. And these circular references are a bad practice.

Created a new file, Libraries/Color/NativeOrDynamicColorType.js, that contains the export type NativeOrDynamicColorType = ... definition. Changed all the import type {NativeOrDynamicColorType} from instances to reference the new file.

Microsoft Reviewers: Open in CodeFlow

@tom-un tom-un requested a review from acoates-ms as a code owner September 5, 2019 23:13
@tom-un tom-un self-assigned this Sep 5, 2019
@tom-un tom-un merged commit 20c3913 into master Sep 6, 2019
@acoates-ms acoates-ms deleted the NativeOrDynamicColorType branch October 21, 2019 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants