[Fabric] Enable CI for building RNTester w/ Fabric macOS #1686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Saad Najmi <sanajmi@microsoft.com>
…componentview # Conflicts: # React/Fabric/Mounting/ComponentViews/InputAccessory/RCTInputAccessoryComponentView.mm # React/Fabric/Mounting/UIView+ComponentViewProtocol.mm
…ponentviewdescriptor
added 18 commits
January 24, 2023 11:46
|
All merged... I guess we can convert this to a "Enable macOS Fabric CI" PR |
|
Very nice! |
shwanton
changed the title
Saadnajmi
approved these changes
Jan 25, 2023
shwanton
added a commit
to shwanton/react-native-macos
that referenced
this pull request
Feb 13, 2023
) * [Fabric] Shim RCTSwitchComponentView * Add missing tags * [Fabric] Shim RCTImage * Shim RCTTextInput * Shim RCTSurfaceTouchHandler * Shim NSTouch in RCTUIKit * Shim RCTComponentViewDescriptor * Fix RCTLegacyViewManagerInteropComponentView * Fix Fabric crash setting frame * Fix crash w/ first responder * Fix RCTFindTextInputWithNativeId * Shim macOS scale utils * Shim RCTUITouch -> NSEvent * [Fabric] Fix UIKit Shim * [Fabric] Fix RCTUILabel shim * [Fabric] Fix RCTSliderComponent shim * [Fabric] Disable UIApplicationWillTerminateNotification on macOS * [Fabric] Don't check alpha for NSView * [Fabric] Add missing tags * [Fabric] Remove double import * [Fabric] Fix RCTTouchEvent Shim * Update React/Fabric/Mounting/RCTComponentViewDescriptor.h Co-authored-by: Saad Najmi <sanajmi@microsoft.com> * [Fabric] Remove duplicate RCTUITouch def * [Fabric] Remove duplicate RCTUITouch def * [Fabric] Fix whitespace * [Fabric] Enable fabric macOS builds on CI * [Fabric] Add missing tag Co-authored-by: Shawn Dempsey <shawndempsey@fb.com> Co-authored-by: Saad Najmi <sanajmi@microsoft.com>
shwanton
added a commit
to shwanton/react-native-macos
that referenced
this pull request
Mar 10, 2023
) * [Fabric] Shim RCTSwitchComponentView * Add missing tags * [Fabric] Shim RCTImage * Shim RCTTextInput * Shim RCTSurfaceTouchHandler * Shim NSTouch in RCTUIKit * Shim RCTComponentViewDescriptor * Fix RCTLegacyViewManagerInteropComponentView * Fix Fabric crash setting frame * Fix crash w/ first responder * Fix RCTFindTextInputWithNativeId * Shim macOS scale utils * Shim RCTUITouch -> NSEvent * [Fabric] Fix UIKit Shim * [Fabric] Fix RCTUILabel shim * [Fabric] Fix RCTSliderComponent shim * [Fabric] Disable UIApplicationWillTerminateNotification on macOS * [Fabric] Don't check alpha for NSView * [Fabric] Add missing tags * [Fabric] Remove double import * [Fabric] Fix RCTTouchEvent Shim * Update React/Fabric/Mounting/RCTComponentViewDescriptor.h Co-authored-by: Saad Najmi <sanajmi@microsoft.com> * [Fabric] Remove duplicate RCTUITouch def * [Fabric] Remove duplicate RCTUITouch def * [Fabric] Fix whitespace * [Fabric] Enable fabric macOS builds on CI * [Fabric] Add missing tag Co-authored-by: Shawn Dempsey <shawndempsey@fb.com> Co-authored-by: Saad Najmi <sanajmi@microsoft.com>
shwanton
added a commit
to shwanton/react-native-macos
that referenced
this pull request
Mar 10, 2023
) * [Fabric] Shim RCTSwitchComponentView * Add missing tags * [Fabric] Shim RCTImage * Shim RCTTextInput * Shim RCTSurfaceTouchHandler * Shim NSTouch in RCTUIKit * Shim RCTComponentViewDescriptor * Fix RCTLegacyViewManagerInteropComponentView * Fix Fabric crash setting frame * Fix crash w/ first responder * Fix RCTFindTextInputWithNativeId * Shim macOS scale utils * Shim RCTUITouch -> NSEvent * [Fabric] Fix UIKit Shim * [Fabric] Fix RCTUILabel shim * [Fabric] Fix RCTSliderComponent shim * [Fabric] Disable UIApplicationWillTerminateNotification on macOS * [Fabric] Don't check alpha for NSView * [Fabric] Add missing tags * [Fabric] Remove double import * [Fabric] Fix RCTTouchEvent Shim * Update React/Fabric/Mounting/RCTComponentViewDescriptor.h Co-authored-by: Saad Najmi <sanajmi@microsoft.com> * [Fabric] Remove duplicate RCTUITouch def * [Fabric] Remove duplicate RCTUITouch def * [Fabric] Fix whitespace * [Fabric] Enable fabric macOS builds on CI * [Fabric] Add missing tag Co-authored-by: Shawn Dempsey <shawndempsey@fb.com> Co-authored-by: Saad Najmi <sanajmi@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
Fabric can be enabled when building RNTester w/o build issues.
USE_FABRIC=1 bundle exec pod installEnable CI for building RNTester w/ Fabric macOS
Changelog
[macOS] [ADDED] - Enable CI for building RNTester w/ Fabric macOS
Test Plan
macOS Fabric DebugCI job should pass