Skip to content

[Fabric] Enable CI for building RNTester w/ Fabric macOS #1686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 54 commits into from
Jan 25, 2023
Merged

[Fabric] Enable CI for building RNTester w/ Fabric macOS #1686

Changes from all commits
Commits
Show all changes
54 commits
Select commit Hold shift + click to select a range
19fab59
[Fabric] Shim RCTSwitchComponentView
Jan 21, 2023
a41fb9d
Add missing tags
Jan 21, 2023
24aeaaa
[Fabric] Shim RCTImage
Jan 21, 2023
072141f
Shim RCTTextInput
Jan 24, 2023
5ffd762
Shim RCTSurfaceTouchHandler
Jan 24, 2023
5ce9035
Shim NSTouch in RCTUIKit
Jan 24, 2023
f83ff50
Shim RCTComponentViewDescriptor
Jan 24, 2023
729d54a
Fix RCTLegacyViewManagerInteropComponentView
Jan 24, 2023
958a058
Fix Fabric crash setting frame
Jan 24, 2023
21bb1e4
Fix crash w/ first responder
Jan 24, 2023
816ff1a
Fix RCTFindTextInputWithNativeId
Jan 24, 2023
26a2713
Shim macOS scale utils
Jan 24, 2023
f17846d
Shim RCTUITouch -> NSEvent
Jan 24, 2023
0a4b202
[Fabric] Fix UIKit Shim
Jan 24, 2023
b6d48ea
[Fabric] Fix RCTUILabel shim
Jan 24, 2023
238d2c0
[Fabric] Fix RCTSliderComponent shim
Jan 24, 2023
bae1e1a
[Fabric] Disable UIApplicationWillTerminateNotification on macOS
Jan 24, 2023
f5e8278
[Fabric] Don't check alpha for NSView
Jan 24, 2023
7796cc7
[Fabric] Add missing tags
Jan 24, 2023
b1d9c7a
[Fabric] Remove double import
Jan 24, 2023
719b5cb
[Fabric] Fix RCTTouchEvent Shim
Jan 24, 2023
d4265bb
Update React/Fabric/Mounting/RCTComponentViewDescriptor.h
shwanton Jan 24, 2023
369b3c5
Merge remote-tracking branch 'microsoft/main' into fabric/shim-rcttex…
Jan 24, 2023
ab012b0
Merge remote-tracking branch 'microsoft/main' into fabric/fix-interop…
Jan 24, 2023
6ff64dd
Merge remote-tracking branch 'microsoft/main' into fabric/shim-rctswi…
Jan 24, 2023
a1b7d74
Merge branch 'fabric/test-success-build' into fabric/shim-rctimage
Jan 24, 2023
5a1326a
Merge remote-tracking branch 'microsoft/main' into fabric/shim-rctsur…
Jan 24, 2023
c23ac76
Merge remote-tracking branch 'microsoft/main' into fabric/shim-rctcom…
Jan 24, 2023
e26653a
Merge branch 'fabric/test-success-build' into fabric/fix-shims-build
Jan 24, 2023
fb2e1fa
Merge branch 'fabric/shim-rcttextinput' into fabric/test-success-build
Jan 24, 2023
d63f732
Merge branch 'fabric/fix-interopcomponentview' into fabric/test-succe…
Jan 24, 2023
32b783a
Merge branch 'fabric/shim-rctswitchcomponentview' into fabric/test-su…
Jan 24, 2023
e84976e
Merge branch 'fabric/shim-rctimage' into fabric/test-success-build
Jan 24, 2023
da865b0
Merge branch 'fabric/shim-rctsurfacetouchhandler' into fabric/test-su…
Jan 24, 2023
8c3cc77
Merge branch 'fabric/shim-rctcomponentviewdescriptor' into fabric/tes…
Jan 24, 2023
ef3beab
Merge branch 'fabric/fix-shims-and-build' into fabric/test-success-build
Jan 24, 2023
dfb4cd8
[Fabric] Remove duplicate RCTUITouch def
Jan 24, 2023
3f79c79
[Fabric] Remove duplicate RCTUITouch def
Jan 24, 2023
bd9e521
Merge branch 'fabric/fix-shims-and-build' into fabric/test-success-build
Jan 24, 2023
c24946c
[Fabric] Fix whitespace
Jan 24, 2023
c943074
Merge branch 'fabric/fix-shims-and-build' into fabric/test-success-build
Jan 24, 2023
3c937f7
[Fabric] Enable fabric macOS builds on CI
Jan 24, 2023
604fc9d
[Fabric] Add missing tag
Jan 24, 2023
61de9cb
Merge remote-tracking branch 'microsoft/main' into fabric/shim-rctimage
Jan 24, 2023
60f4d6a
Merge remote-tracking branch 'microsoft/main' into fabric/shim-rcttex…
Jan 25, 2023
0fda1d0
Merge remote-tracking branch 'microsoft/main' into fabric/shim-rctswi…
Jan 25, 2023
ceedf39
Merge remote-tracking branch 'microsoft/main' into fabric/fix-shims-a…
Jan 25, 2023
65e0e11
Merge remote-tracking branch 'microsoft/main' into fabric/shim-rctimage
Jan 25, 2023
c6899a1
Merge remote-tracking branch 'microsoft/main' into fabric/test-succes…
Jan 25, 2023
8434b7c
Merge branch 'fabric/shim-rcttextinput' into fabric/test-success-build
Jan 25, 2023
9c17e01
Merge branch 'fabric/shim-rctswitchcomponentview' into fabric/test-su…
Jan 25, 2023
2b623a4
Merge branch 'fabric/fix-shims-and-build' into fabric/test-success-build
Jan 25, 2023
1cc998c
Merge branch 'fabric/shim-rctimage' into fabric/test-success-build
Jan 25, 2023
fcf7d8f
Merge remote-tracking branch 'microsoft/main' into fabric/test-succes…
Jan 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .ado/apple-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,15 +80,15 @@ jobs:
xcode_destination: 'platform=macOS,arch=x86_64'
xcode_actions: 'build'
use_fabric: '0'
'macOS Fabric Debug':
packager_platform: 'macos'
xcode_sdk: macosx
xcode_scheme: 'RNTester-macOS'
xcode_configuration: 'Debug'
xcode_destination: 'platform=macOS,arch=x86_64'
xcode_actions: 'build test'
use_fabric: '1'
# Disable failing job
# 'macOS Fabric Debug':
# packager_platform: 'macos'
# xcode_sdk: macosx
# xcode_scheme: 'RNTester-macOS'
# xcode_configuration: 'Debug'
# xcode_destination: 'platform=macOS,arch=x86_64'
# xcode_actions: 'build test'
# use_fabric: '1'
# 'macOS Fabric Release':
# packager_platform: 'macos'
# xcode_sdk: macosx
Expand Down