[WIP] Merge up to March 16, 2023 #1758
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ebook#36210) Summary: Pull Request resolved: facebook#36210 One of the circular dependencies we have in OSS was between React-Codegen and React-Fabric. React-Codegen generates component which has to depends on React-Fabric because they need to use the files contained in the `react/renderer/view` folder. React-Fabric contains some components that depends on RNCore, which was generated inside the React-Codegen folder. This change generates the RNCore components inside the `ReactCommon/react/renderer/components/rncore` folder, breaking the dependency as `rncore` folder is now contained by React-Fabric itself. **Fun Fact:** That's how it always should have been. There was already a line in the `.gitignore` to exclude the content of `ReactCommon/react/renderer/components/rncore` folder. I guess that with some of the refactoring/previous projects on Codegen, this requirements has slipped. ## Changelog: [iOS][Breaking] - generates RNCore components inside the ReactCommon folder and create a new pod for platform-specific ImageManager classes Reviewed By: sammy-SC, dmytrorykun Differential Revision: D43304641 fbshipit-source-id: ebb5033ce73dbcd03f880c3e204511fdce04b816
… Frameworks Summary: By leveraging the `PUBLIC_HEADERS_FOLDER_PATH` build settings of Xcode, we can instruct cocoapods to generate the frameworks Headers in a specific folder, for example the `React` folder. This allows us to maintain the `#include`/`#import` structure, even if the framework has a different name. However, we need to update the search paths to take into account this extra folder. ## Changelog: [iOS][Changed] - Generate RCTFabric framework's headers in the React folder Reviewed By: sammy-SC, dmytrorykun Differential Revision: D43425677 fbshipit-source-id: 94a4f3a3c7de86341b3ce3457704e6b8fb9a588e
…36148) Summary: Pull Request resolved: facebook#36148 This change enables 4 noew tests to make sure that `use_frameworks!` with the New Architecture don't break Note: We may have to publish the codegen to make this work on CircleCI properly ## Changelog: [iOS][Added] - Added tests for use_frameworks! with the new architecture Reviewed By: cortinico, dmytrorykun Differential Revision: D43271625 fbshipit-source-id: fe1fa4be660f933e0113f44a0467eaa1fa3669ca
Summary: Pull Request resolved: facebook#36221 As the title says. allow-large-files Changelog: [Android] [Changed] - Flipper to 0.182.0 Reviewed By: lblasa Differential Revision: D43444516 fbshipit-source-id: 33c2cd4bdf98dc3f7037774003bfdfde2123d8cd
…in settings.gradle.kts (facebook#36188) Summary: Relative path in conditional IF in settings.gradle.kts doesn't work when it try to build (`yarn install-android-jsc`) a package that isn't in root dir and needs of react-native-gradle-plugin or when it try to run rn-tester. When trying to compile rn-tester (`yarn install-android-jsc` command) the error below: ```Shell arthur@assuncao � ~/projects/react-native-test/react-native/packages/rn-tester � � main � yarn install-android-jsc yarn run v1.22.19 $ ../../gradlew :packages:rn-tester:android:app:installJscDebug Starting a Gradle Daemon (subsequent builds will be faster) FAILURE: Build failed with an exception. * What went wrong: Project directory '/home/arthur/projects/react-native-test/react-native/packages/rn-tester' is not part of the build defined by settings file '/home/arthur/projects/react-native-test/react-native/settings.gradle.kts'. If this is an unrelated build, it must have its own settings file. * Try: > Run with --stacktrace option to get the stack trace. > Run with --info or --debug option to get more log output. * Get more help at https://help.gradle.org BUILD FAILED in 8s error Command failed with exit code 1. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. ``` ## Changelog [INTERNAL] [FIXED] - Fix conditional to include rn-tester and react-native-gradle-plugin in settings.gradle.kts. <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> Pull Request resolved: facebook#36188 Test Plan: Execute rn-tester like [(RN-Tester Readme)](https://github.com/facebook/react-native/blob/main/packages/rn-tester/README.md). After my changes, the output of `yarn install-android-jsc` is: ```Shell [... many of the other tasks completed above] > Task :packages:rn-tester:android:app:compileJscDebugJavaWithJavac Note: Some input files use or override a deprecated API. Note: Recompile with -Xlint:deprecation for details. > Task :packages:rn-tester:android:app:stripJscDebugDebugSymbols Unable to strip the following libraries, packaging them as they are: libicu_common.so. > Task :packages:rn-tester:android:app:installJscDebug Installing APK 'app-jsc-arm64-v8a-debug.apk' on 'ASUS_Z01KD - 8.0.0' for :packages:rn-tester:android:app:jsc-debug Installed on 1 device. BUILD SUCCESSFUL in 31m 53s 121 actionable tasks: 121 executed Done in 1913.92s. ``` This PR Resolves facebook#36187 Reviewed By: rshest Differential Revision: D43393440 Pulled By: cortinico fbshipit-source-id: 824644aa77147b3747007908db11fe9c120ad92f
… message (facebook#36220) Summary: Having custom commit message script is not an option for `main` branch, because we have internal tooling, which strips `[x]` tags from commit messages before merging them into `main` branch. Instead of constant commit message, we are now using a tag which will be concatenated with the commit message, which was entered via interactive commit dialog, see demo below. ## Changelog [Internal] - updated validation in bumping packages script Pull Request resolved: facebook#36220 Test Plan: https://user-images.githubusercontent.com/28902667/220163767-015bf37b-6914-4df2-84d9-aa25fb2887d3.mov Reviewed By: cortinico Differential Revision: D43443597 Pulled By: hoxyq fbshipit-source-id: 08e5e08524a1d934fbb35529e025358d7bf3b203
Summary: Callling `getReactApplicationContextIfActiveOrWarn` from `invalidate` will always warn because the context is deactivated, which is preventing us from cleaning up these listeners. Changelog: [Internal] Reviewed By: jehartzog Differential Revision: D43352929 fbshipit-source-id: f29564a290a6c93b2304865d445829f5e486d84f
Summary: > [Codegen 85] The parses/flow/components/schema.js and parses/typescript/components/schema.js are the same. Move the schema.js from the one of the two folders to the parsers common root. Delete the other. Update the references to use the shared file. Part of the Codegen ☂️ Issue facebook#34872 ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Internal] [Changed] - Consolidated the schema.js files for parses/flow/components and parses/typescript/components to a common root. Pull Request resolved: facebook#36219 Test Plan: Run ```yarn jest react-native-codegen``` Reviewed By: christophpurrer Differential Revision: D43444666 Pulled By: cipolleschi fbshipit-source-id: 24d791fd3a8110730d3f6054497ea3a31549a5a5
…cebook#36209) Summary: Pull Request resolved: facebook#36209 ThisChange automatically enable the RuntimeScheduler when the new architecture is enabled, both on RNester and in the Template app. Note that no migration steps are required. ## Changelog [iOS][Changed] - Automatically install the RuntimeScheduler Reviewed By: sammy-SC Differential Revision: D43392059 fbshipit-source-id: 609ded9bdc3db13a0d54ff44d0d4687dfc8617a5
Summary: Changelog: [Internal] Reviewed By: rshest Differential Revision: D42961391 fbshipit-source-id: d07f8627a59d43e762bddb0641b3961806e9a7ec
…SC from Maven Central (facebook#36232) Summary: Pull Request resolved: facebook#36232 Seems like RN Tester is crashing for JSC debug/release. This happens because RN Tester ends up fetching JSC from Maven Central which contains older versions of the artifacts (r17) which are not compatible with our setup AND are missing `libjsc.so`. This is happening as our file layout is a bit different than a regular NPM project so the repository declaration for JSC, being `../jsc-android/dist` from React Native root ends in the wrong folder. In this specifically I: - Add an excludeModule for "org.webkit:android-jsc" on Maven Central inside RNGP - Remove the allproject{repositories{}} block which was overriding RNGP configuration - Add a specific repository declaration inside RN Tester to point to where JSC effectively lives Changelog: [Internal] [Changed] - RNGP - Fix RNTester crashing for JSC and safeguard against fetching JSC from Maven Central Reviewed By: sshic Differential Revision: D43462015 fbshipit-source-id: db830d7567bbf7dd91412df417418aa61a0ca8fe
Summary: This change bumps Flipper to 0.182.0, mirroring the [Android Commit](facebook@8fae37e) allow-large-files ## Changelog: [iOS][Changed] - Bump Flipper to 0.182.0 Reviewed By: dmytrorykun Differential Revision: D43454236 fbshipit-source-id: c852520d1e7f3a386a2fac11318a9fb6e868b520
Summary: Pull Request resolved: facebook#36233 Bump RNGP to 0.72.4 Changelog: [Internal] [Changed] - Bump RNGP to 0.72.4 Reviewed By: cipolleschi, hoxyq Differential Revision: D43445016 fbshipit-source-id: 4d8b0b05da44fb433909ec6be64156234c4e0051
Summary: This adds a series of examples for TextInput styles to screenshot test, specifically the ones which are projected to Android as spans. This will be used in refactoring to verify we do not change visual output. Changelog: [Internal][Added] - Add "Text Styles" TextInput Example Reviewed By: cortinico Differential Revision: D43158004 fbshipit-source-id: adaecf0e37941e66e280db282e2631a95b08b27a
Summary: [Changelog][Internal] This adds a method, `emitDeviceEvent` to the C++ API of TurboModules, which allows to make calls to JS's `RCTDeviceEventEmitter.emit` from a C++ TurboModules. This is a very common pattern, specifically for the VR apps, but not only for them - e.g. Desktop fork also has a [custom implementation for this](https://www.internalfb.com/code/fbsource/third-party/microsoft-fork-of-react-native/react-native-utils/RCTEventEmitter.cpp). Note that my original intent was to actually backport the latter, however there are some complications with wiring things in a robust way, without exposing too much stuff and relying on singletons or folly::dynamic. So I ended up adding it to the TurboModule API itself and use the scheduler/JSI facilities instead. This approach is arguably well self-contained, uses high level APIs, and shouldn't be abusable much. Since I was trying to avoid usage of folly::dynamic in this case, I used a kind of "value factory" pattern instead in order to send the arguments to the JS thread in a thread safe way (see [the discussion here](https://fb.workplace.com/groups/rn.fabric/permalink/1398711453593610/)). Reviewed By: christophpurrer Differential Revision: D43466326 fbshipit-source-id: a3cb8359d08a46421559edd0f854772863cb5c39
Summary: Simple optimization to exit before iterating through the hit path if the event name doesn't match. Changelog: [Android][Internal] - Optimization for natively-driven Animated PointerEvents to early exit during matching in EventAnimationDriverMatchSpec. This should have no effect if you are not using PointerEvents Reviewed By: lunaleaps Differential Revision: D43400457 fbshipit-source-id: fe8d811d371c78622cd4f3f9cd469cff9ccce585
Summary: Changelog: [Android][Fixed] Resolved bug with Text components in new arch losing text alignment state. Reviewed By: mdvacca Differential Revision: D34108943 fbshipit-source-id: 3992e9406345be919b5e3595fc1f9e61cf67a699
Summary: Pull Request resolved: facebook#36227 This is needed for the next Gradle major (8.x) and re-aligns us with the Kotlin version in fbsource Changelog: [Android] [Changed] - Kotlin to 1.7.22 for Gradle allow-large-files Reviewed By: rybalkinsd Differential Revision: D43445999 fbshipit-source-id: 85be1bbb4b5ac1664b5090688b688a4e50c3d80a
Summary: I noticed this stale directory and snapshot tests for RN-Tester. We might as well just remove them. ## Changelog [INTERNAL] [REMOVED] - Remove more tvos remnants Pull Request resolved: facebook#36240 Test Plan: CI should pass. Reviewed By: cipolleschi Differential Revision: D43495264 Pulled By: cortinico fbshipit-source-id: 7286cf6805e12249db5d71bcaa9a91bc947102ca
Summary:
I've just tested the nightly and the build from source is broken as the `repositories{}` block is missing.
Normally RNGP will take care of setting repositories for everyone, but this is triggered by the app-module.
When building from source, the app module of the user is isolated from the included build of React Native,
therefore the repositories{} definitions are not passed over.
Without this, the build fails with:
```
Cannot resolve external dependency ... because no repositories are defined
```
Changelog:
[Internal] [Changed] - Re-add repositories{} block to allow for build-from-source
Reviewed By: cipolleschi
Differential Revision: D43501011
fbshipit-source-id: b41c56c62839163ad210e7e303940dec0a9001da
…erated|intermediate]**` Summary: I'm widening the exclude for GenerateCodegenSchemaTask input files. This is needed before we can migrate to Gradle 8.x as one of the build warning we have is now converted to a build failure. The reason why this is needed is because GenerateCodegenSchemaTask ends up picking up a file that gets generated by `react-native bundle`. While the file is ignored by the Codegen, Gradle detects a clash between the two tasks. This solves the issue completely. Changelog: [Internal] [Changed] - RNGP - GenerateCodegenSchemaTask should exclude all of `**/build/[generated|intermediate]**` Reviewed By: cipolleschi Differential Revision: D43501129 fbshipit-source-id: 49311b833d6b59d4e67e87c535a424a1db1321e6
… external native builds (facebook#36253) Summary: Pull Request resolved: facebook#36253 Another build warning that got converted into a failure in Gradle 8.x Specifically here as we're running 4 native builds in parallel for RN Tester, but they all originate from 2 CMake intermediates files (one set for Debug and one for Release), Gradle raises a warning. Here I'm fixing this warning by specifying an explicit ordering between those tasks. Changelog: [Internal] [Changed] - Gradle 8.x prep - specify task dependency between mergeNativeLibs and external native builds Reviewed By: cipolleschi Differential Revision: D43501128 fbshipit-source-id: bb40ae902157ce97683f42124ec65f2bc0d73405
Summary: When developing the changes to support `use_frameworks!`, I may have forgotten to update the script that generate the `FabricComponentProvider` for the open source (and I may have changed directly that file manually to make everything work). This change restore the generator, using the right `#import statement` allow-large-files ## Changelog [internal] - Update plugin generator Reviewed By: arushikesarwani94 Differential Revision: D43504184 fbshipit-source-id: a89455b62115f6dc2054f804241fd3834056f1b3
Summary: This diff is a retry of shipping D43180893 (facebook@89ef5bd), which got backed out in D43350025 (facebook@1f151e0) due to issues in iOS RN apps. I've exclude iOS apps in this diff. I am planning to have the iOS implementation for the TraceUpdateOverlay native component to fill the gap with lower priority. Changelog: [Internal] Reviewed By: javache Differential Revision: D43409501 fbshipit-source-id: fe8bb5654862f0b5e9054a97ae1f4cde573bb3e0
Summary: Opts `fbsource//xplat/js/react-native-github/packages/rn-tester:RNTesterIntegrationTests` out of Buck2 runs as the target fails in the analysis stage due to some flavor issues. I did experiment with just resolving the flavor issues but several more nontrivial issues show up in the build graph the deeper you go and I think this target is going to require a bit more of a deep dive, so just disabling it to unblock buck2 CI rollout for now. Reviewed By: bujar Differential Revision: D43505883 fbshipit-source-id: 672dc6aea345a8c0396f6a0e3d549016fe1f7c45
…k#36177) Summary: Pull Request resolved: facebook#36177 react_native_assert calls C `assert()`, where XCode does not have a built-in breakpoint navigator to hook to assertion failures (though you can add a symbolic breakpoint to "abort()" to get the effect). This changes the Apple implemented of `react_native_assert()` to use `NSCAssert` under the hood. This is safe to use in C functions, but will be trapped by the default XCode exceptions breakpoint navigator. Changelog: [iOS][Fixed] - Use NSCAssert() in react_native_assert instead of C assert() Reviewed By: cipolleschi Differential Revision: D43275024 fbshipit-source-id: 43c4e4f1ae6b99f32634d4b1880bce712c3ae8f6
Summary: Quick refactor of refactor TextLayoutManager.isRTL() method to cleanup the method and remove lint warning changelog: [internal] internal Reviewed By: javache Differential Revision: D43888197 fbshipit-source-id: 779fb84527f95b3c04504eaa4302be55ab328634
Summary: Refactor usages of TextLayoutManager.sTextPaintInstance changelog: [internal] internal Reviewed By: javache Differential Revision: D43888689 fbshipit-source-id: 64a198f3ca07e32666701204d94e6e75b3ab53ad
Summary: Updates the default set of `"exports"` condition names in our `ReactNativeEnv` for Jest, so that it aligns with the defaults in React Native CLI (react-native-community/cli#1862). Also includes a subtle update to how this is accomplished. Instead of overriding `exportConditions()`, we assign to the underlying class property — this allows users (once jestjs/jest#13989 is merged) to override `customExportConditions` via [`testEnvironmentOptions`](https://jestjs.io/docs/configuration#testenvironmentoptions-object). ```js preset: 'react-native', testEnvironmentOptions: { customExportConditions: ['test', 'react-native'], }, ``` Changelog: [Internal] Reviewed By: jacdebug Differential Revision: D43879056 fbshipit-source-id: 86fffe2b5fdf9d8492d25b8b12a78be75b5fa3be
…ok#36397) Summary: - Add .d.ts files for generators - export each generators because `react-native-windows` need its own selection of generators. ## Changelog [GENERAL] [CHANGED] - Add minimum necessary .d.ts files to react-native-codegen (2) Pull Request resolved: facebook#36397 Test Plan: `npm run build` in `packages/react-native-codegen` and see all .d.ts files appear in `lib`. Checked .d.ts file in typescript playground. Reviewed By: rshest Differential Revision: D43941811 Pulled By: cipolleschi fbshipit-source-id: 28f5bd56f27531ecf25223620a580358018b779d
Summary: I found Animated components like `View`, `Text`, `ScrollView`, `Image` ref type inferred as `any` when ref callback used.  this is happening because of `unknown` type is included as union type as below.  So I excluded `unknown` type inferring via fixing `TAugmentRef` utility type. Result below!  ## Changelog [GENERAL] [FIXED] - fix animated components ref type inferred `any` <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> Pull Request resolved: facebook#36472 Test Plan: Ran `yarn test-typescript` and `yarn test-typescript-offline` with no errors. Reviewed By: cipolleschi Differential Revision: D44055510 Pulled By: dmytrorykun fbshipit-source-id: 0d380a2c2198c84d586889e912dec5d2304c213a
Summary: Pull Request resolved: facebook#36495 It looks like Jest is not running `babel/transform-modules-commonjs` on all files, and therefore when including `"import"` as a Package Exports condition in Jest, this misbehaved (facebook@0a3c555). This is a hotfix to restore CI stability. Changelog: [Fix][Internal] Hotfix adjusting Jest changes added in facebook@0a3c555 Reviewed By: cipolleschi, hoxyq Differential Revision: D44130442 fbshipit-source-id: 6407519d0d5459ef422afe21be26a2e3141bedf3
Summary:
There's an error in the `d.ts` file for EventEmitter which causes the following error:
```
This expression is not constructable.
Type 'typeof import(".../vendor/emitter/EventEmitter")' has no construct signatures.
const emitter = new EventEmitter();
~~~~~~~~~~~~
```
See https://github.com/facebook/react-native/blob/dce9d8d5de381fe53760ddda0d6cbbdfb5be00e4/Libraries/vendor/emitter/EventEmitter.js#L63
## Changelog
<!-- Help reviewers and the release process by writing your own changelog entry.
Pick one each for the category and type tags:
[GENERAL] [FIXED] -Fixes an issue with the EventEmitter type definition file
For more details, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->
Pull Request resolved: facebook#36462
Reviewed By: cipolleschi
Differential Revision: D44130846
Pulled By: javache
fbshipit-source-id: 64cecdf55e58b99b243392811226e5095d5dc006
…egen (facebook#36498) Summary: The supported `CodegenTypes` aren't provided in the docs, which leads to many issues for developers working to transition native components to support Fabric. However, explicit error messages are provided in many cases (e.g., to use specific numeric types instead of `number` attributes or to remove nested optionals in arrays). This isn't the case for the common use case of TypeScript functions, which are very commonly used for event handlers in native components (such as `onChange`), forcing devs to search their way through the `react-native` codebase until they find [this file](https://github.com/facebook/react-native/blob/681d7f8113d2b5e9d6966255ee6c72b50a7d488a/Libraries/Types/CodegenTypes.js#L18). By providing an explicit error message, we can significantly improve developer experience for those working to transition libraries/components, leading to higher Fabric adoption. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [GENERAL] [ADDED] - Create explicit error message for TypeScript functions used as props in Codegen components, redirecting devs to the supported function types `BubblingEventHandler` and `DirectEventHandler`. Pull Request resolved: facebook#36498 Test Plan: * `yarn run lint` shows no errors * no impact on `yarn && yarn jest react-native-codegen`, which failed 362 tests before and after my changes. Reviewed By: cipolleschi, sshic Differential Revision: D44132960 Pulled By: dmytrorykun fbshipit-source-id: d805ec8403613bf4e070cbd2904ff5a2648ec5fc
Summary: Changelog: [iOS][Changed] - Give precedence to `textContentType` property for backwards compat as mentioned in facebook#36229 (comment) Reviewed By: necolas Differential Revision: D44106291 fbshipit-source-id: 5702d7f171735d1abe6cfbc9ca1ad8f21751d51e
…ReferenceAnnotation() (facebook#36463) Summary: > [Codegen 91] Extract the inner switch in typescript/modules/index.js at line to parse the case TSTypereference ([lines](https://github.com/facebook/react-native/blob/main/packages/react-native-codegen/src/parsers/typescript/modules/index.js#L194-L275))into a function translateTypeReferenceAnnotation() (the goal is to try and get a simpler switch statement and to spot structural similiarities between the flow and typescript index.js files) Part of Issue facebook#34872 ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [INTERNAL] [CHANGED] - Extract inner switch case 'TSTypereference' to function translateTypeReferenceAnnotation(). Pull Request resolved: facebook#36463 Test Plan: - yarn lint - yarn run flow - yarn test react-native-codegen Reviewed By: cortinico Differential Revision: D44027755 Pulled By: cipolleschi fbshipit-source-id: b32d6adc56fcd0e1b42c255b16828b2306941d57
…tiveComponentType` fn in `parser-commons.js` (facebook#36466) Summary: >[Codegen 95] Extract the `defaultExports.forEach(statement =>` (Flow, TS) function in `parser-commons`, so that it accept a Parser parameter to unify the behaviors between flow and typescript. The Parser object needs to be enriched with all the methods to extract the required information from the Node, if they are not there yet. ### Changes - merged TS & Flow parsers' logic for `defaultExports.forEach(statement =>` of `/components/index.js:findComponentConfig()` into; - `findNativeComponentType` fn to `parsers-commons.js` - add `getTypeArgumentParamsFromDeclaration` & `getNativeComponentType` fn's - add **_tests_** for getTypeArgumentParamsFromDeclaration & `getNativeComponentType` fn's ## Changelog [INTERNAL] [CHANGED] - Merge `defaultExports.forEach(statement => ...` (Flow, TS) to `findNativeComponentType` fn in `parser-commons.js` Pull Request resolved: facebook#36466 Test Plan: - `yarn lint && yarn run flow && yarn jest react-native` ⇒ � Reviewed By: rshest Differential Revision: D44088862 Pulled By: cipolleschi fbshipit-source-id: 91bf0edcd53b2e054160af34d7c128355c178b26
Summary: Fix typo `RCTCustomRefreshContolProtocol` > `RCTCustomRefreshControlProtocol` ## Changelog [INTERNAL] [FIXED] - Fixed typo RCTCustomRefreshControlProtocol Pull Request resolved: facebook#36363 Test Plan: none Reviewed By: cortinico Differential Revision: D44024938 Pulled By: cipolleschi fbshipit-source-id: 1fbc4e75361334586e46e14ee746cbb94d230a92
Summary: Changelog: [Internal] - Add platform test for pointercancel events caused by touch scrolling This diff adds a new ported Web Platform Test which [verifies that pointercancel events are properly emitted once a touch causes scrolling](https://github.com/web-platform-tests/wpt/blob/master/pointerevents/pointerevent_pointercancel_touch.html). Reviewed By: lunaleaps Differential Revision: D43855277 fbshipit-source-id: 94a106058ba2c5e5fe4c1980519ceceddb2bb389
Summary: Changelog: [iOS][Internal] - Refactor PointerEvent emitting into its own gesture recognizer In doing some exploration of a full e2e implementation of the click event I found pretty early on the necessity of addressing the pointerCancel on scroll functionality which, to implement properly without degrading the existing touch gesture handler — involves extracting all the pointer event handling code written so far into its own gesture handler so it can "fail" (when a scroll view wants to take priority) without affecting the existing touch handlers. This diff is only a refactor and doesn't add/change any new functionality. allow-large-files Reviewed By: sammy-SC Differential Revision: D43372806 fbshipit-source-id: e16f75121fd121d3f82ab43cfc6fab0629654f26
|
hmmm is it better off merge it to your existing .71 branch rather than main branch for this Pr? |
This one will have to go to main after #1661 lands. I'll probably rebase this. |
|
Closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
56 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remaining diffs to resolve: