Console.assert doesn't exist in the simulator, so this will always re… #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dbox unless the debugger is attached (in which case it runs through chrome which has all the console methods already defined)
acoates-ms
approved these changes
Oct 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…dbox unless the debugger is attached (in which case it runs through chrome which has all the console methods already defined)
Overview
Add a check that assert exists. This is also a problem several people are reporting in the community so we should push this back to facebook as well.
Focus areas to test
Launching RNC and Polyester no longer redbox and tests can run without the remote debugger attached.
Microsoft Reviewers: Open in CodeFlow