Skip to content

Console.assert doesn't exist in the simulator, so this will always re… #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 31, 2019
Merged

Console.assert doesn't exist in the simulator, so this will always re… #184

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a0bd3c
console.assert doesn't exist in the simulator, so this will always re…
HeyImChris Oct 31, 2019
9ee9606
a more proper fix is to check that console has the assert property
HeyImChris Oct 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Libraries/polyfills/console.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,7 +560,7 @@ if (global.nativeLoggingHook) {
// TODO(T43930203): remove this special case once originalConsole.assert properly checks
// the condition
if (methodName === 'assert') {
if (!arguments[0]) {
if (!arguments[0] && originalConsole.hasOwnProperty('assert')) {
originalConsole.assert(...arguments);
}
} else {
Expand Down