Skip to content

Conversation

hansenyy
Copy link

@hansenyy hansenyy commented Nov 1, 2019

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

ScriptStore and RuntimeHolder are currently only used by Microsoft/react-native-windows. This PR removes them from this repository.

Microsoft Reviewers: Open in CodeFlow

@hansenyy hansenyy requested review from a team, acoates-ms and mganandraj November 1, 2019 20:40
@acoates-ms
Copy link
Collaborator

Do you have the PR for RNW ready? (or does it not even need one?) -- Shouldnt you remove the usage from RNW first?

@hansenyy
Copy link
Author

hansenyy commented Nov 1, 2019

Do you have the PR for RNW ready? (or does it not even need one?) -- Shouldnt you remove the usage from RNW first?

See microsoft/react-native-windows#3577.

@pull-bot
Copy link

pull-bot commented Nov 1, 2019

Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against d84aa6b

@hansenyy hansenyy requested a review from NickGerleman November 1, 2019 20:43
@acoates-ms
Copy link
Collaborator

Let make sure the RNW one lands before you submit this one..

Copy link

@NikoAri NikoAri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

hansenyy added a commit to microsoft/react-native-windows that referenced this pull request Nov 1, 2019
This commit moves ScriptStore and RuntimeHolder from RN to RNW. See also microsoft/react-native-macos#185.
@hansenyy hansenyy merged commit bce68a3 into microsoft:master Nov 1, 2019
@hansenyy hansenyy deleted the moveScriptStore branch November 1, 2019 22:14
lenaic pushed a commit to lenaic/react-native-macos that referenced this pull request Jul 4, 2025
Summary:
Changelog: [Internal] - Update `react-native/debugger-frontend` from 35c4630...51a91a2

Resyncs `react-native/debugger-frontend` from GitHub - see `rn-chrome-devtools-frontend` [changelog](facebook/react-native-devtools-frontend@35c4630...51a91a2).

### Changelog

| Commit | Author | Date/Time | Subject |
| ------ | ------ | --------- | ------- |
| [51a91a2ad](facebook/react-native-devtools-frontend@51a91a2ad) | Ruslan Lesiutin (28902667+hoxyq@users.noreply.github.com) | 2025-07-04T14:04:02+01:00 | [bump: react-devtools@6.1.4 (microsoft#189)](facebook/react-native-devtools-frontend@51a91a2ad) |
| [761b96907](facebook/react-native-devtools-frontend@761b96907) | Vitali Zaidman (vzaidman@gmail.com) | 2025-07-04T12:55:39+01:00 | [fixed missing new line before string error causes (microsoft#186)](facebook/react-native-devtools-frontend@761b96907) |
| [7774c38db](facebook/react-native-devtools-frontend@7774c38db) | Alex Hunt (hello@alexhunt.dev) | 2025-06-30T13:20:49+01:00 | [Disable request initiator panel in NetworkItemView (microsoft#185)](facebook/react-native-devtools-frontend@7774c38db) |

Reviewed By: huntie

Differential Revision: D77795834

fbshipit-source-id: 3c30f8e87593687415538902734b09b3144b70a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants