Add memory management and concurrency tests plans to our fork of Reac… #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markavitale
approved these changes
Nov 4, 2019
|
Do we plan to submit this change to the FB repo? |
Comment on lines
63
to
66
| "RNTesterIntegrationTests\/testAccessibilityManagerTest", | ||
| "RNTesterIntegrationTests\/testAppEventsTest", | ||
| "RNTesterIntegrationTests\/testSyncMethodTest", | ||
| "RNTesterIntegrationTests\/testWebSocketTest" |
There was a problem hiding this comment.
Do you have a sense of the problem? Maybe it's easy to just fix?
There was a problem hiding this comment.
I'm missing from the diff/commit notes, but what exactly did we change so these could be re-enabled?
There was a problem hiding this comment.
Pushed them up while they were still failing. Tom pushed a header fix today that stopped the inconsistent failures
Eventually it'd be great to. Short term we're still aiming to just get the proper testing infrastructure up and running, but when we finally merge our branch back into FB's, this should go too. |
added 2 commits
November 7, 2019 10:17
…ministic errors can occur in the header maps of RCTText. Fix by forward declaring @protocols in headers, and #import the necessary headers in the .m files that need them.
… RunLoop has executed a block during shutdown, which results in this->m_shutdown being deferenced to deallocated memory. Capture a shared_ptr to this instead of a raw `this` in the lambdas.
tom-un
approved these changes
Nov 7, 2019
lenaic
pushed a commit
to lenaic/react-native-macos
that referenced
this pull request
Jul 4, 2025
Summary: Changelog: [Internal] - Update `react-native/debugger-frontend` from 35c4630...51a91a2 Resyncs `react-native/debugger-frontend` from GitHub - see `rn-chrome-devtools-frontend` [changelog](facebook/react-native-devtools-frontend@35c4630...51a91a2). ### Changelog | Commit | Author | Date/Time | Subject | | ------ | ------ | --------- | ------- | | [51a91a2ad](facebook/react-native-devtools-frontend@51a91a2ad) | Ruslan Lesiutin (28902667+hoxyq@users.noreply.github.com) | 2025-07-04T14:04:02+01:00 | [bump: react-devtools@6.1.4 (microsoft#189)](facebook/react-native-devtools-frontend@51a91a2ad) | | [761b96907](facebook/react-native-devtools-frontend@761b96907) | Vitali Zaidman (vzaidman@gmail.com) | 2025-07-04T12:55:39+01:00 | [fixed missing new line before string error causes (microsoft#186)](facebook/react-native-devtools-frontend@761b96907) | | [7774c38db](facebook/react-native-devtools-frontend@7774c38db) | Alex Hunt (hello@alexhunt.dev) | 2025-06-30T13:20:49+01:00 | [Disable request initiator panel in NetworkItemView (microsoft#185)](facebook/react-native-devtools-frontend@7774c38db) | Reviewed By: huntie Differential Revision: D77795834 fbshipit-source-id: 3c30f8e87593687415538902734b09b3144b70a4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t Native
Please select one of the following
React Native has limited tooling running as it executes tests. We should perform more rigorous memory management checks given the memory issues we've seen in the past with RN. While we're at it, let's add a test plan for code concurrency. RN has a lot of multithreadedness that should have race conditions and execution various orders verified.
We should enable TSan as well, but right now so many tests crash with TSan on, it makes more sense to leave it off for now and then go through the tests one at a time and get them working with TSan before turning it on permanently.
Focus areas to test
Only impacts our tests.
Microsoft Reviewers: Open in CodeFlow