Revert an RTL change we made that FB fixed at a lower level, making t… #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…his obsolete. This file now aligns with what FB has in their repo
|
👍 |
acoates-ms
approved these changes
Nov 20, 2019
anandrajeswaran
approved these changes
Nov 20, 2019
markavitale
approved these changes
Nov 20, 2019
christophpurrer
pushed a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jul 23, 2025
Summary: Pull Request resolved: facebook#52793 Changelog: [Internal] - Update `react-native/debugger-frontend` from 8dc0d5b...a7e4f59 Resyncs `react-native/debugger-frontend` from GitHub - see `rn-chrome-devtools-frontend` [changelog](facebook/react-native-devtools-frontend@8dc0d5b...a7e4f59). ### Changelog [General][Fixed] fixed stack trace parsing failure for certain frames that are special to Hermes that do not exist in V8. | Commit | Author | Date/Time | Subject | | ------ | ------ | --------- | ------- | | [a7e4f5967](facebook/react-native-devtools-frontend@a7e4f5967) | Vitali Zaidman (vzaidman@gmail.com) | 2025-07-23T17:04:33+01:00 | [allow parsing special hermes eval stack trace frames (microsoft#196)](facebook/react-native-devtools-frontend@a7e4f5967) | | [12ae91ad4](facebook/react-native-devtools-frontend@12ae91ad4) | Vitali Zaidman (vzaidman@gmail.com) | 2025-07-23T16:37:55+01:00 | [allow parsing stack traces that end with "skipping x frames" (microsoft#195)](facebook/react-native-devtools-frontend@12ae91ad4) | | [875a31a90](facebook/react-native-devtools-frontend@875a31a90) | Vitali Zaidman (vzaidman@gmail.com) | 2025-07-15T13:45:16+01:00 | [fixed general contribution guide and added meta contribution guide in pr template (microsoft#194)](facebook/react-native-devtools-frontend@875a31a90) | Reviewed By: huntie Differential Revision: D78817268 fbshipit-source-id: 7e266041b3df7ecbcded6e57cb51bd4647dc835d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…his obsolete. This file now aligns with what FB has in their repo
Please select one of the following
This was added back in January 2019 to get RTL support in safe views. Facebook has since added their own logic to do this at the Yoga layer, which is a more fundamental layer. Facebook's fix is more central and should be kept, while this one is now superfluous.
facebook@21363ad
Focus areas to test
The padding switches sides between RTL/LTR with or without this code, making this code obsolete.
Microsoft Reviewers: Open in CodeFlow