Tomun/fixflow #196
Merged
Tomun/fixflow #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
anandrajeswaran
approved these changes
Dec 1, 2019
christophpurrer
pushed a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jul 23, 2025
Summary: Pull Request resolved: facebook#52793 Changelog: [Internal] - Update `react-native/debugger-frontend` from 8dc0d5b...a7e4f59 Resyncs `react-native/debugger-frontend` from GitHub - see `rn-chrome-devtools-frontend` [changelog](facebook/react-native-devtools-frontend@8dc0d5b...a7e4f59). ### Changelog [General][Fixed] fixed stack trace parsing failure for certain frames that are special to Hermes that do not exist in V8. | Commit | Author | Date/Time | Subject | | ------ | ------ | --------- | ------- | | [a7e4f5967](facebook/react-native-devtools-frontend@a7e4f5967) | Vitali Zaidman (vzaidman@gmail.com) | 2025-07-23T17:04:33+01:00 | [allow parsing special hermes eval stack trace frames (microsoft#196)](facebook/react-native-devtools-frontend@a7e4f5967) | | [12ae91ad4](facebook/react-native-devtools-frontend@12ae91ad4) | Vitali Zaidman (vzaidman@gmail.com) | 2025-07-23T16:37:55+01:00 | [allow parsing stack traces that end with "skipping x frames" (microsoft#195)](facebook/react-native-devtools-frontend@12ae91ad4) | | [875a31a90](facebook/react-native-devtools-frontend@875a31a90) | Vitali Zaidman (vzaidman@gmail.com) | 2025-07-15T13:45:16+01:00 | [fixed general contribution guide and added meta contribution guide in pr template (microsoft#194)](facebook/react-native-devtools-frontend@875a31a90) | Reviewed By: huntie Differential Revision: D78817268 fbshipit-source-id: 7e266041b3df7ecbcded6e57cb51bd4647dc835d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
The Flow checks have been broken in the Microsoft react-native fork for some time. This change adds Flow, Jest, Lint, and Prettier tests to the PR tests. It also fixes Flow breaks that have been in the repo since the last merge from .59 to .60.
While fixing and testing the Flow changes I discovered that the mac keyboard scroll events were not working. This change also restores the mac keyboard scroll events (scroll by using arrow keys, etc.). The mac keyboard scrolling depends on a native ScrollView prop
onKeyDown. This can easily be confused with generic key events so I renamedonKeyDowntoonScrollKeyDown.Focus areas to test
(optional)
Microsoft Reviewers: Open in CodeFlow