[RNTester] Remove need to update lockfile after cutting new build #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There’s no real need for RNTester to use MS specific versions. So simply removing those from the system will make the lockfile stable, as far as versions go, just like the upstream version. Closes #218
|
This doesn't affect which code gets included in by RNTester, right? Like its still using the local copy of everything? |
acoates-ms
approved these changes
Jan 8, 2020
|
Correct. These are all setup as “development pods” (i.e. they use the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There’s no real need for RNTester to use MS specific versions. So simply
removing those from the system will make the lockfile stable, as far as
versions go, just like the upstream version.
Closes #218
Microsoft Reviewers: Open in CodeFlow