MacOS mouse events show up at wrong locations #260
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
There's a bug where mac os events are received with locations relative to either the screen or the window. Different click styles (light trackpad tap vs. harder trackpad click) appear to dictate which event type we have and thus, which coordinate system we're receiving events in. Right now we were treating every click as if the event location is relative to the window, but we receive some click events relative to the screen. We need to handle those and convert them properly to the right coordinate system.
There's an unknown of why these aren't just MouseDown/MouseUp events. It's possible React Native is gobbling up the OS events somewhere and giving these back, but a search of the repo found no obvious NSEventType manipulation. This did reveal a tangential bug in RNTester where every other mouse down event is throwing an RCTAssert on MacOS which eats up that event. I'm looking into that bug next.
Focus areas to test
Microsoft Reviewers: Open in CodeFlow