Skip to content

MacOS mouse events show up at wrong locations #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 20, 2020
Merged

MacOS mouse events show up at wrong locations #260

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dca6a7f
macos mouse events showing up at wrong locations sometimes fix
HeyImChris Mar 20, 2020
c42a250
cache some vars
HeyImChris Mar 20, 2020
dc53a71
minor var renames
HeyImChris Mar 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions Libraries/ActionSheetIOS/RCTActionSheetManager.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,15 +157,25 @@ - (void)presentViewController:(UIViewController *)alertController
view = [self.bridge.uiManager viewForReactTag:anchorViewTag];
event = [view.window currentEvent];
}
NSView *superview = [view superview];
if (event && view) {
origin = [view convertPoint:[event locationInWindow] fromView:nil];
// On a macOS trackpad, soft taps are received as sysDefined event types. SysDefined event locations are relative to the screen so we have to convert those separately.
NSPoint eventLocationRelativeToWindow = NSZeroPoint;
CGPoint eventLocationInWindow = [event locationInWindow];
if ([event type] == NSEventTypeSystemDefined) { // light tap event relative to screen
eventLocationRelativeToWindow = [[view window] convertRectFromScreen:NSMakeRect(eventLocationInWindow.x, eventLocationInWindow.y, 0, 0)].origin;
} else { // full click events are relative to the window
eventLocationRelativeToWindow = eventLocationInWindow;
}
origin = [view convertPoint:eventLocationRelativeToWindow fromView:nil];
} else if (view) {
origin = NSMakePoint(NSMidX(view.superview.frame), NSMidY(view.superview.frame));
CGRect superviewFrame = [superview frame];
origin = NSMakePoint(NSMidX(superviewFrame), NSMidY(superviewFrame));
} else {
origin = [NSEvent mouseLocation];
}

[menu popUpMenuPositioningItem:menu.itemArray.firstObject atLocation:origin inView:view.superview];
[menu popUpMenuPositioningItem:menu.itemArray.firstObject atLocation:origin inView:superview];
#endif // ]TODO(macOS ISS#2323203)
}

Expand Down