-
Notifications
You must be signed in to change notification settings - Fork 149
Add react-native run-macos
command
#300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code analysis results:
shellcheck
found some issues.
Nice ✨ |
Please select one of the following
This change adds a
react-native run-macos
command similar torun-ios
andrun-android
. It will build the macOS app and then launch it.The change also modified the macos-generator command to output an updated final message that informs the user to run via
npx react-native run-macos
.A minor bug in the macos xcodeproj template is fixed: it was creating an App bundle Id in the form
org.reactjs.native.AppName.AppName
instead oforg.reactjs.AppName.AppName
.The new
run-macos
command is registered inreact-native.config.js
for macos platform.scripts/packager.sh
was updated so that when the "Launch Packager" custom build step in React runs, it correctly starts the packager in react-native-macos mode similar to whatyarn start:macos
does.This command is patterned after the
run-ios
command which is implemented at https://github.com/react-native-community/cli/tree/master/packages/platform-ios/src/commands/runIOS.Focus areas to test
Microsoft Reviewers: Open in CodeFlow