fix(ios): make new_architecture_enabled? respect RCT_NEW_ARCH_ENABLED=0

[kraenhansen]

Description

It seems to me the read of the RCT_NEW_ARCH_ENABLED environment variable is broken:

RCT_NEW_ARCH_ENABLED=0 ruby -e 'puts ENV.fetch("RCT_NEW_ARCH_ENABLED", false) ? "enabled" : "disabled"'

prints

enabled

I.e. when setting RCT_NEW_ARCH_ENABLED to 0, new_architecture_enabled? returns the string "0" which is truthy.

Platforms affected

• Android
• iOS
• macOS
• visionOS
• Windows

Test plan

• Run RCT_NEW_ARCH_ENABLED=0 pod install and see how the RCT_NEW_ARCH_ENABLED=1 is incorrectly appended to the "OTHER_CPLUSPLUSFLAGS" on the Xcode project.
• Apply this fix and notice how it isn't anymore after running the command again.

[tido64]

Thanks for fixing this. Would you mind adding some test cases here as well:

react-native-test-app/test/test_pod_helpers.rb

Line 51 in 2a5bdd4

def test_new_architecture_enabled?

[kraenhansen]

Added a test and rebased to follow the conventional commit / contributing guidelines 👍

[tido64]

Thanks again ❤️