Skip to content

fix(windows): fix missing images when building with New Arch #2177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2024
Merged

fix(windows): fix missing images when building with New Arch #2177

merged 1 commit into from
Aug 13, 2024

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Aug 13, 2024

Description

Somehow, we managed to use Image instead of Content in the .wapproj, causing them to (occasionally?) not be included in the build.

Resolves #2176.

Platforms affected

  • Android
  • iOS
  • macOS
  • visionOS
  • Windows

Test plan

npm run set-react-version 0.74
cd example
yarn install-windows-test-app --use-fabric
yarn windows

Build should succeed.

@github-actions github-actions bot added the platform: Windows This affects Windows label Aug 13, 2024
@tido64 tido64 merged commit 7d022e0 into trunk Aug 13, 2024
@tido64 tido64 deleted the tido/windows/update-fabric-template branch August 13, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acoates-ms acoates-ms acoates-ms approved these changes

@JasonVMo JasonVMo Awaiting requested review from JasonVMo JasonVMo is a code owner

Assignees
No one assigned
Labels
platform: Windows This affects Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ReactApp package manifest referencing incorrect image assets when building
2 participants
@tido64 @acoates-ms