Skip to content

fix(visionos): fix build failing when Hermes is enabled #2308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 6, 2024
Merged

fix(visionos): fix build failing when Hermes is enabled #2308

merged 3 commits into from
Nov 6, 2024

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Nov 6, 2024 •
edited
Loading

Description

Fix build failing when Hermes is enabled on 0.75 or below.

Platforms affected

  • Android
  • iOS
  • macOS
  • visionOS
  • Windows

Test plan

cd example
USE_HERMES=1 pod install --project-directory=visionos
yarn visionos

@github-actions github-actions bot added platform: iOS This affects iOS platform: macOS This affects macOS platform: visionOS labels Nov 6, 2024
@tido64 tido64 force-pushed the tido/visionos/hermes branch from 567a67c to 50c757d Compare November 6, 2024 13:11
@tido64 tido64 merged commit 9a0d1e1 into trunk Nov 6, 2024
30 checks passed
@tido64 tido64 deleted the tido/visionos/hermes branch November 6, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saadnajmi Saadnajmi Saadnajmi approved these changes

@JasonVMo JasonVMo Awaiting requested review from JasonVMo JasonVMo is a code owner

Assignees
No one assigned
Labels
platform: iOS This affects iOS platform: macOS This affects macOS platform: visionOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tido64 @Saadnajmi