Skip to content

fix(android): force enable New Architecture from 0.77 #2314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2024
Merged

fix(android): force enable New Architecture from 0.77 #2314

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions android/react-native.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,13 @@ ext.isFabricEnabled = { Project project ->
}

ext.isNewArchitectureEnabled = { Project project ->
def newArchEnabled = project.findProperty("react.newArchEnabled")
?: project.findProperty("newArchEnabled")
def NEW_ARCH_ENABLED = "newArchEnabled"
def SCOPED_NEW_ARCH_ENABLED = "react.newArchEnabled"

def newArchEnabled = project.findProperty(SCOPED_NEW_ARCH_ENABLED)
?: project.findProperty(NEW_ARCH_ENABLED)
def version = getPackageVersionNumber("react-native", project.rootDir)
if (newArchEnabled == "true") {
def version = getPackageVersionNumber("react-native", project.rootDir)
def isSupported = version == 0 || version >= v(0, 71, 0)
if (!isSupported) {
throw new GradleException([
Expand All @@ -50,5 +53,13 @@ ext.isNewArchitectureEnabled = { Project project ->
}
return isSupported
}
return false

if (version < v(0, 77, 0)) {
return false
}

// As of 0.77, New Architecture is assumed on and doesn't build otherwise
project.ext[NEW_ARCH_ENABLED] = "true"
project.ext[SCOPED_NEW_ARCH_ENABLED] = "true"
return true
}