-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Remove Prompt from CLI for switching to New Arch and update warning. #15087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| console.log(); | ||
| console.log( | ||
| chalk.blue( | ||
| '🔗 View the list of properties not yet supported in Fabric: https://microsoft.github.io/react-native-windows/docs/new-arch-props/missingProps', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link will be published when 0.80 website is live!
https://microsoft.github.io/react-native-windows/docs/new-arch-props/missingProps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR for reference: microsoft/react-native-windows-samples#1073
vineethkuttan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…icrosoft#15087) * Remove Prompt from CLI for switching to new arch. * Change files * Update oldArchWarning.ts * Update oldArchWarning.ts
…icrosoft#15087) * Remove Prompt from CLI for switching to new arch. * Change files * Update oldArchWarning.ts * Update oldArchWarning.ts
Description
Type of Change
Why
What is the motivation for this change? Add a few sentences describing the context and overall goals of the pull request's commits.
To align with 0.80 version having Fabric New Arch as Default
Resolves #15090
What
What changes were made to the codebase to solve the bug, add the functionality, etc. that you specified above.
Removed the yes/no prompt asked when no template was provided and added 2 new links in warning.
Screenshots
Add any relevant screen captures here from before or after your changes.
Testing
If you added tests that prove your changes are effective or that your feature works, add a few sentences here detailing the added test scenarios.
Optional: Describe the tests that you ran locally to verify your changes.
Changelog
Should this change be included in the release notes: no
Add a brief summary of the change to use in the release notes for the next release.
Microsoft Reviewers: Open in CodeFlow