-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Improve the inspector page name for modern debugger #15375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+48
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
There are a number of changes to other files that do not seem to be related to the change. |
vineethkuttan
approved these changes
Nov 17, 2025
Contributor
vineethkuttan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
vmoroz
reviewed
Nov 17, 2025
vmoroz
reviewed
Nov 17, 2025
vmoroz
reviewed
Nov 17, 2025
vmoroz
reviewed
Nov 17, 2025
vmoroz
reviewed
Nov 17, 2025
vnext/src-win/src/private/specs_DEPRECATED/components/Xaml/XamlHostNativeComponent.js
Show resolved
Hide resolved
vmoroz
approved these changes
Nov 17, 2025
iamAbhi-916
added a commit
to iamAbhi-916/react-native-windows
that referenced
this pull request
Nov 20, 2025
* visual studio 2026 strict check fix * Add HostTargetMetadata with app name and device name for inspector page naming * lint:fix * Change files * revert VS 2026 strict checks fix * review comments
iamAbhi-916
added a commit
to iamAbhi-916/react-native-windows
that referenced
this pull request
Nov 20, 2025
* visual studio 2026 strict check fix * Add HostTargetMetadata with app name and device name for inspector page naming * lint:fix * Change files * revert VS 2026 strict checks fix * review comments
13 tasks
iamAbhi-916
added a commit
that referenced
this pull request
Nov 21, 2025
iamAbhi-916
added a commit
that referenced
this pull request
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
1>when we open devtools the current page target name which shows is React Native Windows (Experimental) this PR enhances it to more informative format that includes: App Name + Device Name
For example: text (CPC-abhij-UF5EG)
2> lint:fix removes deep imports from vnext/src-win/src/private/specs_DEPRECATED/components/Xaml/XamlHostNativeComponent.js.
Type of Change
Why
1>improves page name
2> removes deep imports from vnext/src-win/src/private/specs_DEPRECATED/components/Xaml/XamlHostNativeComponent.js
Resolves [Add Relevant Issue Here]
#15342
sub issue in : #15392
What
App Name is extracted from options.Identity ( didnt use ReactInstanceSettings::DebuggerRuntimeName() is rarely set by apps - it's an optional property that developers must explicitly configure.)
Device Name is the Windows computer name obtained via GetComputerNameW()
Screenshots
Testing
tested in playground.
Changelog
Should this change be included in the release notes: no_
Microsoft Reviewers: Open in CodeFlow