Skip to content

Conversation

@iamAbhi-916
Copy link
Contributor

@iamAbhi-916 iamAbhi-916 commented Nov 15, 2025

Description

1>when we open devtools the current page target name which shows is React Native Windows (Experimental) this PR enhances it to more informative format that includes: App Name + Device Name
For example: text (CPC-abhij-UF5EG)

2> lint:fix removes deep imports from vnext/src-win/src/private/specs_DEPRECATED/components/Xaml/XamlHostNativeComponent.js.

Type of Change

  • New feature (non-breaking change which adds functionality)

Why

1>improves page name
2> removes deep imports from vnext/src-win/src/private/specs_DEPRECATED/components/Xaml/XamlHostNativeComponent.js

Resolves [Add Relevant Issue Here]
#15342
sub issue in : #15392

What

App Name is extracted from options.Identity ( didnt use ReactInstanceSettings::DebuggerRuntimeName() is rarely set by apps - it's an optional property that developers must explicitly configure.)
Device Name is the Windows computer name obtained via GetComputerNameW()

Screenshots

image

Testing

tested in playground.

Changelog

Should this change be included in the release notes: no_

Microsoft Reviewers: Open in CodeFlow

@iamAbhi-916 iamAbhi-916 marked this pull request as ready for review November 17, 2025 04:32
@iamAbhi-916 iamAbhi-916 requested review from a team as code owners November 17, 2025 04:32
@vmoroz
Copy link
Member

vmoroz commented Nov 17, 2025

There are a number of changes to other files that do not seem to be related to the change.
They seem to be unnecessary.

Copy link
Contributor

@vineethkuttan vineethkuttan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@iamAbhi-916 iamAbhi-916 merged commit c0d8888 into microsoft:main Nov 17, 2025
30 checks passed
@iamAbhi-916 iamAbhi-916 deleted the hostTargetMetadata branch November 17, 2025 08:08
iamAbhi-916 added a commit to iamAbhi-916/react-native-windows that referenced this pull request Nov 20, 2025
* visual studio 2026 strict check fix

* Add HostTargetMetadata with app name and device name for inspector page naming

* lint:fix

* Change files

* revert VS 2026 strict checks fix

* review comments
iamAbhi-916 added a commit to iamAbhi-916/react-native-windows that referenced this pull request Nov 20, 2025
* visual studio 2026 strict check fix

* Add HostTargetMetadata with app name and device name for inspector page naming

* lint:fix

* Change files

* revert VS 2026 strict checks fix

* review comments
iamAbhi-916 added a commit that referenced this pull request Nov 21, 2025
* visual studio 2026 strict check fix

* Add HostTargetMetadata with app name and device name for inspector page naming

* lint:fix

* Change files

* revert VS 2026 strict checks fix

* review comments
iamAbhi-916 added a commit that referenced this pull request Nov 21, 2025
* visual studio 2026 strict check fix

* Add HostTargetMetadata with app name and device name for inspector page naming

* lint:fix

* Change files

* revert VS 2026 strict checks fix

* review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants