Skip to content

Conversation

@davidchisnall
Copy link
Collaborator

Longest CI job is now about 7-8 minutes instead of 24. This PR:

  • Removes some of the duplicated jobs that Paul introduced for the cache things.
  • Makes the slowest functionality test run only in release configurations
  • Pulls the LD_PRELOAD test into a separate stage so it can run in parallel with other jobs.

- Don't run an expensive functionality test in debug builds.
- Don't run the different cache configurations (they're probably going
  away soon because they help only in synthetic benchmarks).
The Linux Debug build is currently one of the slowest two, pull out one
phase of it that is independent and allow it to run in parallel with the
other tests.
These take longer, so we want to start them earlier and let the shorter
tests fill in the gaps in scheduling.
Copy link
Member

@mjp41 mjp41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The build produces a binary `libsnmallocshim.so`. This file can be
On ELF platforms, The build produces a binary `libsnmallocshim.so`.
This file can be
`LD_PRELOAD`ed to use the allocator in place of the system allocator, for
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this true on Mac OS X

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, on macOS it produces libsnmallocshim.dyld, which might be useable with DYLD_INSERT_LIBRARIES, but might not, depending on the binary. That seemed too difficult to usefully explain in a README, so I decided not to.

@davidchisnall davidchisnall merged commit 869b22b into master Feb 25, 2019
@davidchisnall davidchisnall deleted the ci branch April 9, 2019 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants