Merge changes required for using snmalloc in FreeBSD libc #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide a hook so that the exported malloc symbols can be weak. This is mostly needed so that rtld, which statically links libc.a, can override the symbols. Add a bootstrap allocator so that statically linked binaries can have their TLS space allocated before malloc is called and uses TLS.
mjp41
previously approved these changes
Jan 17, 2019
Member
mjp41
left a comment
mjp41
left a comment
There was a problem hiding this comment.
LGTM, couple of minor things. I don't think they are essential, so feel free to merge.
Move slow_allocator into a separate header in the snmalloc namespace and rename it for consistency with the rest of the codebase. Delete its copy and move constructors / assignment operators.
mjp41
approved these changes
Jan 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these changes, 32- and 64-bit userland builds, static and dynamically linked 64-bit versions are tested (32-bit ones are not, but hopefully work!).