goto parsing fails with empty target

Symfony's route generator generates a url matcher on disk like so:

<?php
class UrlMatcher {
    public function match($path)
    {
        if ('/path' === $pathinfo) {
            if ('POST' !== $canonicalMethod) {
                $allow[] = 'POST';
                goto not_this_path;
            }
            return array ('_controller' => 'method',  '_route' => 'this_path');
        }
        not_this_path:
        // other routes with their own goto not_that_path
    }
}

PHP seems to allow empty targets, since it runs the code just fine. This is a regression compared to the previous version of the language server.

[jens1o]

When you add any expression below it, it passes:

I know, but the current behaviour is still wrong vs PHP itself. So either there's a bug in php (and thus symfony will have to change their code) or there's a issue with the tolerant-php-parser.

[roblourens]

Hm, so in this case, the next token after the label: is always a close brace or EOF, right (besides whitespace, comment, etc)?

[roblourens]

There's also this case:

goto label;
if (false)
    label:
else
    echo "else\n";

This seems hard to parse. Will think about it.

@roblourens : as far as I can tell yes, but my router usage is so minimal that I'm not sure what other corner cases there might be.

shouldn't this also be tagged as lang server regression? I don't think it errored out on this.