Skip to content

Conversation

@jens1o
Copy link
Contributor

@jens1o jens1o commented Jun 8, 2017

No description provided.

@msftclas
Copy link

msftclas commented Jun 8, 2017

@jens1o,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

/** @var Token */
public $colon;
/**@var StatementNode | StatementNode[] */
/** @var StatementNode | StatementNode[] */

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are spaces between union types allowed? I thought a space separated the type from a description

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's forbidden, but I don't want to break codestyle to be honest.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't break forbidden code style?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, you got it. Until I get a message, I won't break that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does appear to be wrong, at least it isn't parsed by phpDocumentor when it's space-separated. There are a ton of those in the parser, I'll fix them all at once. Also some in the language server.

@roblourens roblourens merged commit 4dfcdb4 into microsoft:master Jun 12, 2017
@jens1o jens1o deleted the jens1o-fix-var-annotations branch June 12, 2017 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants