Normalize spaces in union types in comments ("A | B" -> "A|B") #174
Conversation
|
@TysonAndre, It will cover your contributions to all Microsoft-managed open source projects. |
|
Thanks! I don't think the test files supposed to be changed? |
Mentioned in discussion of https://github.com/Microsoft/tolerant-php-parser/pull/136/files Many IDEs and tools don't expect whitespace, and don't handle this. So, they may act as if only the first type. - https://github.com/php-fig/fig-standards/blob/master/proposed/phpdoc.md#appendix-a-types is a proposal, and is vague about how whitespace is handled outside `<>` - https://github.com/phpDocumentor/phpDocumentor2/blob/develop/docs/references/phpdoc/tags/var.rst is vague - https://github.com/phpDocumentor/ReflectionDocBlock/blob/master/src/DocBlock/Tags/Var_.php doesn't expect any whitespace after `@var` Remove extra space between `@param` and `@return` union types Fix DiagnosticsProvider phpdoc
TysonAndre
force-pushed
the
normalize-space
branch
from
db32892 to
2858366
Compare
|
Reverted the test files. I'm not sure when those changed, must have modified them somehow or checked out a stale version by accident. After this was approved, See https://github.com/Microsoft/tolerant-php-parser/pull/174/files?w=1 |
|
@TysonAndre, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request. |
4 participants
Mentioned in discussion of
https://github.com/Microsoft/tolerant-php-parser/pull/136/files
(Couldn't find the code style guidelines referred to, if any. Is that just referring to the current state?)
Many IDEs and tools don't expect whitespace, and don't handle this.
So, they may act as if only the first type.
is a proposal, and is vague about how whitespace is handled
outside
<>is vague
doesn't expect any whitespace after
@var