Fix incorrect PHPdoc for src/Parser.php, nit on property assignment #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TysonAndre, |
felixfbecker
approved these changes
Sep 15, 2017
roblourens
reviewed
Sep 18, 2017
| return $name; | ||
| }, $node); | ||
| if ($node->nameParts === null && $node->globalSpecifier === null && $node->relativeSpecifier === null) { | ||
| return null; |
Member
There was a problem hiding this comment.
Previously it would return null if $node->nameParts was null, ie if parseDelimitedList returned null. I think this check should be for $nameParts now? Otherwise I agree with not using $node->nameParts to hold a temporary value.
Contributor
Author
There was a problem hiding this comment.
Yes, it should. Missed that.
Clarify phpdoc of parseDelimitedList Don't assign a DelimitedList to node->nameParts, it's declared as an array. (Has no side effects, this is overwritten afterwards unless nameParts was null)
TysonAndre
force-pushed
the
Node-parser-partial-nits
branch
from
841bbda to
1f29666
Compare
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify phpdoc of parseDelimitedList
Don't assign a DelimitedList to node->nameParts,
it's declared as an array.
(Has no side effects, this is overwritten afterwards unless nameParts was null)