Stop including non-php files in validation tests. #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noticed test failures for pgsql.phpunit.xml in the drupal project's test files. (contains the substring ".php") Also, do the matching on the path name, not on the object to string conversion.
|
@TysonAndre, |
roblourens
requested changes
Sep 20, 2017
| foreach (new RecursiveIteratorIterator($iterator) as $file) { | ||
| if (strpos($file, ".php") !== false) { | ||
| $pathName = $file->getPathname(); | ||
| if (preg_match('@\.php$@', $pathName) > 0) { |
Member
There was a problem hiding this comment.
Could you use / as the regex delimiter instead?
roblourens
approved these changes
Sep 20, 2017
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed test failures for pgsql.phpunit.xml in the drupal project's test
files. (contains the substring ".php").
That also included
foo.php.gzAlso, do the matching on the path name, not on the object to string
conversion.