Add diagnostics test #198
Merged
Add diagnostics test #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks, this is awesome! I think the test failures are just what was fixed by the other PR, right? |
Contributor
Author
|
Yes, I see you just merged the other PR so I can rebase this branch on the new master. Just a moment :) |
sunverwerth
force-pushed
the
diag-validation
branch
from
6053925 to
8378884
Compare
Contributor
Author
|
Ok, checks do pass now! Please note that I have only added checks for the ParserGrammar tests, the lexer and validation tests do not do diagnostic checking. But I think this covers plenty of cases for now. |
roblourens
approved these changes
Sep 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added diagnostic tests to the test suite. Works the same as the tree tests.
This includes the .diag files for the current state of the parser.
Additionally I fixed a bug in the DiagnosticsProvider when a use declaration with an empty use clause list is checked.