Support php 8.0 constructor property promotion #324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://wiki.php.net/rfc/constructor_promotion Note that PHP 8.0 will parse visibility modifiers on all parameters, but it will be a compile-time error to use them anywhere except a __construct method. Fixes microsoft#323
roblourens
reviewed
Jun 14, 2020
| @@ -0,0 +1,50 @@ | |||
| [ | |||
Member
There was a problem hiding this comment.
Is parameterPromotion2.php missing?
roblourens
approved these changes
Jun 15, 2020
Member
roblourens
left a comment
roblourens
left a comment
There was a problem hiding this comment.
Thanks! Is this good to be merged even though PHP 8 is not released? Is that proposal stable?
Contributor
Author
I'd consider it to be stable. The php-src PR linked in https://wiki.php.net/rfc/constructor_promotion#php_rfcconstructor_property_promotion was already merged to the 8.0-dev(master) branch, and there's no discussion of changing it on the mailing list. The release managers plan to release 8.0.0 in November 2020 (https://wiki.php.net/todo/php80#timetable) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wiki.php.net/rfc/constructor_promotion
Note that PHP 8.0 will parse visibility modifiers on all parameters,
but it will be a compile-time error to use them anywhere except
a __construct method.
Fixes #323