Skip to content

Warn about missing use variable #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2020
Merged

Warn about missing use variable #325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Node/AnonymousFunctionUseClause.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

namespace Microsoft\PhpParser\Node;

use Microsoft\PhpParser\MissingToken;
use Microsoft\PhpParser\Node;
use Microsoft\PhpParser\Node\DelimitedList\UseVariableNameList;
use Microsoft\PhpParser\Token;
Expand All @@ -17,7 +18,7 @@ class AnonymousFunctionUseClause extends Node {
/** @var Token */
public $openParen;

/** @var UseVariableNameList */
/** @var UseVariableNameList|MissingToken */
public $useVariableNameList;

/** @var Token */
Expand Down
2 changes: 1 addition & 1 deletion src/Parser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3566,7 +3566,7 @@ function ($parentNode) {
return $useVariableName;
},
$anonymousFunctionUseClause
);
) ?: (new MissingToken(TokenKind::VariableName, $this->token->fullStart));
$anonymousFunctionUseClause->closeParen = $this->eat1(TokenKind::CloseParenToken);

return $anonymousFunctionUseClause;
Expand Down
2 changes: 2 additions & 0 deletions tests/cases/parser/anonymousFunctionCreationExpression11.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
<?php
function () use() {};
8 changes: 8 additions & 0 deletions tests/cases/parser/anonymousFunctionCreationExpression11.php.diag
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
[
{
"kind": 0,
"message": "'VariableName' expected.",
"start": 22,
"length": 0
}
]
86 changes: 86 additions & 0 deletions tests/cases/parser/anonymousFunctionCreationExpression11.php.tree
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,86 @@
{
"SourceFileNode": {
"statementList": [
{
"InlineHtml": {
"scriptSectionEndTag": null,
"text": null,
"scriptSectionStartTag": {
"kind": "ScriptSectionStartTag",
"textLength": 6
}
}
},
{
"ExpressionStatement": {
"expression": {
"AnonymousFunctionCreationExpression": {
"staticModifier": null,
"functionKeyword": {
"kind": "FunctionKeyword",
"textLength": 8
},
"byRefToken": null,
"name": null,
"openParen": {
"kind": "OpenParenToken",
"textLength": 1
},
"parameters": null,
"closeParen": {
"kind": "CloseParenToken",
"textLength": 1
},
"anonymousFunctionUseClause": {
"AnonymousFunctionUseClause": {
"useKeyword": {
"kind": "UseKeyword",
"textLength": 3
},
"openParen": {
"kind": "OpenParenToken",
"textLength": 1
},
"useVariableNameList": {
"error": "MissingToken",
"kind": "VariableName",
"textLength": 0
},
"closeParen": {
"kind": "CloseParenToken",
"textLength": 1
}
}
},
"colonToken": null,
"questionToken": null,
"returnType": null,
"otherReturnTypes": null,
"compoundStatementOrSemicolon": {
"CompoundStatementNode": {
"openBrace": {
"kind": "OpenBraceToken",
"textLength": 1
},
"statements": [],
"closeBrace": {
"kind": "CloseBraceToken",
"textLength": 1
}
}
}
}
},
"semicolon": {
"kind": "SemicolonToken",
"textLength": 1
}
}
}
],
"endOfFileToken": {
"kind": "EndOfFileToken",
"textLength": 0
}
}
}