Skip to content

Conversation

@TysonAndre
Copy link
Contributor

@TysonAndre TysonAndre commented Jul 4, 2020

https://wiki.php.net/rfc/match_expression_v2 was approved.

Note that the default keyword and expressions can't be mixed in a
condition list, but this is an error-tolerant parser,
so that check wasn't added.

This was tested against 8.0-dev

https://wiki.php.net/rfc/match_expression_v2 was approved.

Note that the default keyword and expressions can't be mixed in a
condition list, but this is an error-tolerant parser,
so that check wasn't added.

This was tested against a manually rebased branch of the implementation PR.
@TysonAndre
Copy link
Contributor Author

This functionality has been merged into php 8.0-dev. The tests of match continue to work.

Copy link
Member

@roblourens roblourens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@roblourens roblourens merged commit e813b45 into microsoft:master Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants