Add support for PHP 8.0 #[ attribute groups
#341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Looks like a good start to me, thanks! |
TysonAndre
force-pushed
the
attributes-group
branch
from
2deb467 to
d8bb636
Compare
TysonAndre
changed the title
This supports the grouped attributes syntax that will be in PHP 8.0.0RC1. See https://wiki.php.net/rfc/shorter_attribute_syntax_change#secondary_vote Fixes microsoft#320
TysonAndre
force-pushed
the
attributes-group
branch
from
3c03f7f to
3a174a9
Compare
TysonAndre
changed the title
#[ attribute groups
Contributor
Author
|
@roblourens - This is ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supports the grouped attributes syntax that will be in PHP 8.0.0RC1.
See https://wiki.php.net/rfc/shorter_attribute_syntax_change#secondary_vote
Fixes #320