Also handle attributes in new #[MyAttr] class {...}, traits, interfaces
#342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I forgot that anonymous classes were parsed into an ObjectCreationExpression instead. Also support attributes there, cause a diagnostic to be emitted if the attribute group(s) aren't followed by the `class` keyword. For microsoft#320
They were already supported on ClassDeclaration. The php runtime allows attributes on all classlikes, including traits/interfaces.
TysonAndre
changed the title
new #[MyAttr] class {...}new #[MyAttr] class {...}, traits, interfaces
Contributor
Author
|
@roblourens - this is ready for review. I didn't notice anything else missing when working on an application using tolerant-php-parser |
roblourens
approved these changes
Sep 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot that anonymous classes were parsed into an
ObjectCreationExpression instead.
Also support attributes there, cause a diagnostic to be emitted if the
attribute group(s) aren't followed by the
classkeyword.Add attributes support for TraitDeclaration and InterfaceDeclaration
in the same way it was added earlier for ClassDeclaration.
For #320