Add recursion limiter for TypeToString (#3832)

ahejlsberg · web-flow · commit 2b665150f83f · 2026-06-09T20:12:18.000Z
diff --git a/internal/checker/checker.go b/internal/checker/checker.go
diff --git a/internal/checker/flow.go b/internal/checker/flow.go
@@ -1570,7 +1570,7 @@ func (c *Checker) reportFlowControlError(node *ast.Node) {
 	block := ast.FindAncestor(node, ast.IsFunctionOrModuleBlock)
 	sourceFile := ast.GetSourceFileOfNode(node)
 	span := scanner.GetRangeOfTokenAtPosition(sourceFile, block.StatementList().Pos())
-	c.diagnostics.Add(ast.NewDiagnostic(sourceFile, span, diagnostics.The_containing_function_or_module_body_is_too_large_for_control_flow_analysis))
+	c.addDiagnostic(ast.NewDiagnostic(sourceFile, span, diagnostics.The_containing_function_or_module_body_is_too_large_for_control_flow_analysis))
 }
 
 func (c *Checker) isMatchingReference(source *ast.Node, target *ast.Node) bool {
diff --git a/internal/checker/grammarchecks.go b/internal/checker/grammarchecks.go
@@ -19,7 +19,7 @@ func (c *Checker) grammarErrorOnFirstToken(node *ast.Node, message *diagnostics.
 	sourceFile := ast.GetSourceFileOfNode(node)
 	if !c.hasParseDiagnostics(sourceFile) {
 		span := scanner.GetRangeOfTokenAtPosition(sourceFile, node.Pos())
-		c.diagnostics.Add(ast.NewDiagnostic(sourceFile, span, message, args...))
+		c.addDiagnostic(ast.NewDiagnostic(sourceFile, span, message, args...))
 		return true
 	}
 	return false
@@ -28,7 +28,7 @@ func (c *Checker) grammarErrorOnFirstToken(node *ast.Node, message *diagnostics.
 func (c *Checker) grammarErrorAtPos(nodeForSourceFile *ast.Node, start int, length int, message *diagnostics.Message, args ...any) bool {
 	sourceFile := ast.GetSourceFileOfNode(nodeForSourceFile)
 	if !c.hasParseDiagnostics(sourceFile) {
-		c.diagnostics.Add(ast.NewDiagnostic(sourceFile, core.NewTextRange(start, start+length), message, args...))
+		c.addDiagnostic(ast.NewDiagnostic(sourceFile, core.NewTextRange(start, start+length), message, args...))
 		return true
 	}
 	return false
@@ -48,7 +48,7 @@ func (c *Checker) grammarErrorOnNodeSkippedOnNoEmit(node *ast.Node, message *dia
 	if !c.hasParseDiagnostics(sourceFile) {
 		d := NewDiagnosticForNode(node, message, args...)
 		d.SetSkippedOnNoEmit()
-		c.diagnostics.Add(d)
+		c.addDiagnostic(d)
 		return true
 	}
 	return false
@@ -81,7 +81,7 @@ func (c *Checker) checkGrammarRegularExpressionLiteral(node *ast.RegularExpressi
 				lastError.AddRelatedInfo(err)
 			} else if lastError == nil || start != lastError.Pos() {
 				lastError = ast.NewDiagnostic(sourceFile, core.NewTextRange(start, start+length), message, args...)
-				c.diagnostics.Add(lastError)
+				c.addDiagnostic(lastError)
 			}
 		})
 		c.regExpScanner.SetText(sourceFile.Text())
@@ -1208,13 +1208,13 @@ func (c *Checker) checkGrammarForInOrForOfStatement(forInOrOfStatement *ast.ForI
 			if ast.IsInTopLevelContext(asNode) {
 				if !c.hasParseDiagnostics(sourceFile) {
 					if !ast.IsEffectiveExternalModule(sourceFile, c.compilerOptions) {
-						c.diagnostics.Add(createDiagnosticForNode(forInOrOfStatement.AwaitModifier, diagnostics.X_for_await_loops_are_only_allowed_at_the_top_level_of_a_file_when_that_file_is_a_module_but_this_file_has_no_imports_or_exports_Consider_adding_an_empty_export_to_make_this_file_a_module))
+						c.addDiagnostic(createDiagnosticForNode(forInOrOfStatement.AwaitModifier, diagnostics.X_for_await_loops_are_only_allowed_at_the_top_level_of_a_file_when_that_file_is_a_module_but_this_file_has_no_imports_or_exports_Consider_adding_an_empty_export_to_make_this_file_a_module))
 					}
 					switch c.moduleKind {
 					case core.ModuleKindNode16, core.ModuleKindNode18, core.ModuleKindNode20, core.ModuleKindNodeNext:
 						sourceFileMetaData := c.program.GetSourceFileMetaData(sourceFile.Path())
 						if sourceFileMetaData.ImpliedNodeFormat == core.ModuleKindCommonJS {
-							c.diagnostics.Add(createDiagnosticForNode(forInOrOfStatement.AwaitModifier, diagnostics.The_current_file_is_a_CommonJS_module_and_cannot_use_await_at_the_top_level))
+							c.addDiagnostic(createDiagnosticForNode(forInOrOfStatement.AwaitModifier, diagnostics.The_current_file_is_a_CommonJS_module_and_cannot_use_await_at_the_top_level))
 							break
 						}
 						fallthrough
@@ -1227,7 +1227,7 @@ func (c *Checker) checkGrammarForInOrForOfStatement(forInOrOfStatement *ast.ForI
 						}
 						fallthrough
 					default:
-						c.diagnostics.Add(createDiagnosticForNode(forInOrOfStatement.AwaitModifier, diagnostics.Top_level_for_await_loops_are_only_allowed_when_the_module_option_is_set_to_es2022_esnext_system_node16_node18_node20_nodenext_or_preserve_and_the_target_option_is_set_to_es2017_or_higher))
+						c.addDiagnostic(createDiagnosticForNode(forInOrOfStatement.AwaitModifier, diagnostics.Top_level_for_await_loops_are_only_allowed_when_the_module_option_is_set_to_es2022_esnext_system_node16_node18_node20_nodenext_or_preserve_and_the_target_option_is_set_to_es2017_or_higher))
 					}
 				}
 			} else {
@@ -1240,7 +1240,7 @@ func (c *Checker) checkGrammarForInOrForOfStatement(forInOrOfStatement *ast.ForI
 						relatedInfo := createDiagnosticForNode(containingFunc, diagnostics.Did_you_mean_to_mark_this_function_as_async)
 						diagnostic.AddRelatedInfo(relatedInfo)
 					}
-					c.diagnostics.Add(diagnostic)
+					c.addDiagnostic(diagnostic)
 					return true
 				}
 			}
@@ -1702,7 +1702,7 @@ func (c *Checker) checkGrammarAwaitOrAwaitUsing(node *ast.Node) bool {
 						message = diagnostics.X_await_using_statements_are_only_allowed_at_the_top_level_of_a_file_when_that_file_is_a_module_but_this_file_has_no_imports_or_exports_Consider_adding_an_empty_export_to_make_this_file_a_module
 					}
 					diagnostic := ast.NewDiagnostic(sourceFile, span, message)
-					c.diagnostics.Add(diagnostic)
+					c.addDiagnostic(diagnostic)
 					hasError = true
 				}
 				switch c.moduleKind {
@@ -1715,7 +1715,7 @@ func (c *Checker) checkGrammarAwaitOrAwaitUsing(node *ast.Node) bool {
 						if !spanCalculated {
 							span = scanner.GetRangeOfTokenAtPosition(sourceFile, node.Pos())
 						}
-						c.diagnostics.Add(ast.NewDiagnostic(sourceFile, span, diagnostics.The_current_file_is_a_CommonJS_module_and_cannot_use_await_at_the_top_level))
+						c.addDiagnostic(ast.NewDiagnostic(sourceFile, span, diagnostics.The_current_file_is_a_CommonJS_module_and_cannot_use_await_at_the_top_level))
 						hasError = true
 						break
 					}
@@ -1738,7 +1738,7 @@ func (c *Checker) checkGrammarAwaitOrAwaitUsing(node *ast.Node) bool {
 					} else {
 						message = diagnostics.Top_level_await_using_statements_are_only_allowed_when_the_module_option_is_set_to_es2022_esnext_system_node16_node18_node20_nodenext_or_preserve_and_the_target_option_is_set_to_es2017_or_higher
 					}
-					c.diagnostics.Add(ast.NewDiagnostic(sourceFile, span, message))
+					c.addDiagnostic(ast.NewDiagnostic(sourceFile, span, message))
 					hasError = true
 				}
 			}
@@ -1758,7 +1758,7 @@ func (c *Checker) checkGrammarAwaitOrAwaitUsing(node *ast.Node) bool {
 					relatedInfo := NewDiagnosticForNode(container, diagnostics.Did_you_mean_to_mark_this_function_as_async)
 					diagnostic.AddRelatedInfo(relatedInfo)
 				}
-				c.diagnostics.Add(diagnostic)
+				c.addDiagnostic(diagnostic)
 				hasError = true
 			}
 		}
diff --git a/internal/checker/jsx.go b/internal/checker/jsx.go
@@ -147,7 +147,7 @@ func (c *Checker) checkJsxOpeningLikeElementOrOpeningFragment(node *ast.Node) {
 			}
 			var diags []*ast.Diagnostic
 			if !c.checkTypeRelatedToEx(tagType, elementTypeConstraint, c.assignableRelation, tagName, diagnostics.Its_type_0_is_not_a_valid_JSX_element_type, &diags) {
-				c.diagnostics.Add(ast.NewDiagnosticChain(diags[0], diagnostics.X_0_cannot_be_used_as_a_JSX_component, scanner.GetTextOfNode(tagName)))
+				c.addDiagnostic(ast.NewDiagnosticChain(diags[0], diagnostics.X_0_cannot_be_used_as_a_JSX_component, scanner.GetTextOfNode(tagName)))
 			}
 		} else {
 			c.checkJsxReturnAssignableToAppropriateBound(c.getJsxReferenceKind(node), c.getReturnTypeOfSignature(sig), node)
@@ -189,7 +189,7 @@ func (c *Checker) checkJsxReturnAssignableToAppropriateBound(refKind JsxReferenc
 		c.checkTypeRelatedToEx(elemInstanceType, combined, c.assignableRelation, openingLikeElement.TagName(), diagnostics.Its_element_type_0_is_not_a_valid_JSX_element, &diags)
 	}
 	if len(diags) != 0 {
-		c.diagnostics.Add(ast.NewDiagnosticChain(diags[0], diagnostics.X_0_cannot_be_used_as_a_JSX_component, scanner.GetTextOfNode(openingLikeElement.TagName())))
+		c.addDiagnostic(ast.NewDiagnosticChain(diags[0], diagnostics.X_0_cannot_be_used_as_a_JSX_component, scanner.GetTextOfNode(openingLikeElement.TagName())))
 	}
 }
 
@@ -554,7 +554,7 @@ func (c *Checker) resolveJsxOpeningLikeElement(node *ast.Node, candidatesOutArra
 				sourceFile := ast.GetSourceFileOfNode(node)
 				typeArgumentList := node.TypeArgumentList()
 				loc := core.NewTextRange(scanner.SkipTrivia(sourceFile.Text(), typeArgumentList.Loc.Pos()), typeArgumentList.Loc.End())
-				c.diagnostics.Add(ast.NewDiagnostic(sourceFile, loc, diagnostics.Expected_0_type_arguments_but_got_1, 0, len(typeArguments)))
+				c.addDiagnostic(ast.NewDiagnostic(sourceFile, loc, diagnostics.Expected_0_type_arguments_but_got_1, 0, len(typeArguments)))
 			}
 			return fakeSignature
 		}
diff --git a/internal/checker/printer.go b/internal/checker/printer.go
@@ -187,6 +187,12 @@ func (c *Checker) TypeToStringEx(t *Type, enclosingDeclaration *ast.Node, flags
 }
 
 func (c *Checker) typeToStringEx(t *Type, enclosingDeclaration *ast.Node, flags TypeFormatFlags, vc *VerbosityContext) string {
+	// Serialization of types can lead to (lazy) resolution of members, which can cause diagnostics that again require
+	// serialization of types. This can potentially result in infinite recursion and stack overflows. To prevent that,
+	// after a certain number of recursive invocations the function simply returns "?".
+	if c.serializationLevel >= maxSerializationLevel {
+		return "?"
+	}
 	newLine := ""
 	if flags&TypeFormatFlagsMultilineObjectLiterals != 0 {
 		newLine = "\n"
@@ -204,7 +210,9 @@ func (c *Checker) typeToStringEx(t *Type, enclosingDeclaration *ast.Node, flags
 	defer func() {
 		nodeBuilder.verbosity = oldVerbosity
 	}()
+	c.serializationLevel++
 	typeNode := nodeBuilder.TypeToTypeNode(t, enclosingDeclaration, combinedFlags, nodebuilder.InternalFlagsNone, nil)
+	c.serializationLevel--
 	if typeNode == nil {
 		panic("should always get typenode")
 	}
diff --git a/internal/checker/relater.go b/internal/checker/relater.go
@@ -418,7 +418,7 @@ func (c *Checker) reportDiagnostic(diagnostic *ast.Diagnostic, diagnosticOutput
 		if diagnosticOutput != nil {
 			*diagnosticOutput = append(*diagnosticOutput, diagnostic)
 		} else {
-			c.diagnostics.Add(diagnostic)
+			c.addDiagnostic(diagnostic)
 		}
 	}
 }
diff --git a/testdata/baselines/reference/compiler/noTypeToStringRecursion.errors.txt b/testdata/baselines/reference/compiler/noTypeToStringRecursion.errors.txt
@@ -0,0 +1,13 @@
+noTypeToStringRecursion.ts(3,7): error TS7023: 'f' implicitly has return type 'any' because it does not have a return type annotation and is referenced directly or indirectly in one of its return expressions.
+noTypeToStringRecursion.ts(3,20): error TS1360: Type 'number' does not satisfy the expected type '() => any'.
+
+
+==== noTypeToStringRecursion.ts (2 errors) ====
+    // https://github.com/microsoft/typescript-go/issues/3805
+    
+    const f = () => 42 satisfies typeof f;
+          ~
+!!! error TS7023: 'f' implicitly has return type 'any' because it does not have a return type annotation and is referenced directly or indirectly in one of its return expressions.
+                       ~~~~~~~~~
+!!! error TS1360: Type 'number' does not satisfy the expected type '() => any'.
+    
diff --git a/testdata/baselines/reference/compiler/noTypeToStringRecursion.symbols b/testdata/baselines/reference/compiler/noTypeToStringRecursion.symbols
@@ -0,0 +1,9 @@
+//// [tests/cases/compiler/noTypeToStringRecursion.ts] ////
+
+=== noTypeToStringRecursion.ts ===
+// https://github.com/microsoft/typescript-go/issues/3805
+
+const f = () => 42 satisfies typeof f;
+>f : Symbol(f, Decl(noTypeToStringRecursion.ts, 2, 5))
+>f : Symbol(f, Decl(noTypeToStringRecursion.ts, 2, 5))
+
diff --git a/testdata/baselines/reference/compiler/noTypeToStringRecursion.types b/testdata/baselines/reference/compiler/noTypeToStringRecursion.types
@@ -0,0 +1,12 @@
+//// [tests/cases/compiler/noTypeToStringRecursion.ts] ////
+
+=== noTypeToStringRecursion.ts ===
+// https://github.com/microsoft/typescript-go/issues/3805
+
+const f = () => 42 satisfies typeof f;
+>f : () => any
+>() => 42 satisfies typeof f : () => any
+>42 satisfies typeof f : 42
+>42 : 42
+>f : () => any
+
diff --git a/testdata/tests/cases/compiler/noTypeToStringRecursion.ts b/testdata/tests/cases/compiler/noTypeToStringRecursion.ts
@@ -0,0 +1,5 @@
+// @noEmit: true
+
+// https://github.com/microsoft/typescript-go/issues/3805
+
+const f = () => 42 satisfies typeof f;

Original file line number	Diff line number	Diff line change
`@@ -1570,7 +1570,7 @@ func (c Checker) reportFlowControlError(node ast.Node) {`
`1570`	`1570`	`block := ast.FindAncestor(node, ast.IsFunctionOrModuleBlock)`
`1571`	`1571`	`sourceFile := ast.GetSourceFileOfNode(node)`
`1572`	`1572`	`span := scanner.GetRangeOfTokenAtPosition(sourceFile, block.StatementList().Pos())`
`1573`		`- c.diagnostics.Add(ast.NewDiagnostic(sourceFile, span, diagnostics.The_containing_function_or_module_body_is_too_large_for_control_flow_analysis))`
	`1573`	`+ c.addDiagnostic(ast.NewDiagnostic(sourceFile, span, diagnostics.The_containing_function_or_module_body_is_too_large_for_control_flow_analysis))`
`1574`	`1574`	`}`
`1575`	`1575`
`1576`	`1576`	`func (c Checker) isMatchingReference(source ast.Node, target *ast.Node) bool {`
Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ func (c Checker) grammarErrorOnFirstToken(node ast.Node, message *diagnostics.`
`19`	`19`	`sourceFile := ast.GetSourceFileOfNode(node)`
`20`	`20`	`if !c.hasParseDiagnostics(sourceFile) {`
`21`	`21`	`span := scanner.GetRangeOfTokenAtPosition(sourceFile, node.Pos())`
`22`		`- c.diagnostics.Add(ast.NewDiagnostic(sourceFile, span, message, args...))`
	`22`	`+ c.addDiagnostic(ast.NewDiagnostic(sourceFile, span, message, args...))`
`23`	`23`	`return true`
`24`	`24`	`}`
`25`	`25`	`return false`
`@@ -28,7 +28,7 @@ func (c Checker) grammarErrorOnFirstToken(node ast.Node, message *diagnostics.`
`28`	`28`	`func (c Checker) grammarErrorAtPos(nodeForSourceFile ast.Node, start int, length int, message *diagnostics.Message, args ...any) bool {`
`29`	`29`	`sourceFile := ast.GetSourceFileOfNode(nodeForSourceFile)`
`30`	`30`	`if !c.hasParseDiagnostics(sourceFile) {`
`31`		`- c.diagnostics.Add(ast.NewDiagnostic(sourceFile, core.NewTextRange(start, start+length), message, args...))`
	`31`	`+ c.addDiagnostic(ast.NewDiagnostic(sourceFile, core.NewTextRange(start, start+length), message, args...))`
`32`	`32`	`return true`
`33`	`33`	`}`
`34`	`34`	`return false`
`@@ -48,7 +48,7 @@ func (c Checker) grammarErrorOnNodeSkippedOnNoEmit(node ast.Node, message *dia`
`48`	`48`	`if !c.hasParseDiagnostics(sourceFile) {`
`49`	`49`	`d := NewDiagnosticForNode(node, message, args...)`
`50`	`50`	`d.SetSkippedOnNoEmit()`
`51`		`- c.diagnostics.Add(d)`
	`51`	`+ c.addDiagnostic(d)`
`52`	`52`	`return true`
`53`	`53`	`}`
`54`	`54`	`return false`
`@@ -81,7 +81,7 @@ func (c Checker) checkGrammarRegularExpressionLiteral(node ast.RegularExpressi`
`81`	`81`	`lastError.AddRelatedInfo(err)`
`82`	`82`	`} else if lastError == nil \|\| start != lastError.Pos() {`
`83`	`83`	`lastError = ast.NewDiagnostic(sourceFile, core.NewTextRange(start, start+length), message, args...)`
`84`		`- c.diagnostics.Add(lastError)`
	`84`	`+ c.addDiagnostic(lastError)`
`85`	`85`	`}`
`86`	`86`	`})`
`87`	`87`	`c.regExpScanner.SetText(sourceFile.Text())`
`@@ -1208,13 +1208,13 @@ func (c Checker) checkGrammarForInOrForOfStatement(forInOrOfStatement ast.ForI`
`1208`	`1208`	`if ast.IsInTopLevelContext(asNode) {`
`1209`	`1209`	`if !c.hasParseDiagnostics(sourceFile) {`
`1210`	`1210`	`if !ast.IsEffectiveExternalModule(sourceFile, c.compilerOptions) {`
`1211`		`- c.diagnostics.Add(createDiagnosticForNode(forInOrOfStatement.AwaitModifier, diagnostics.X_for_await_loops_are_only_allowed_at_the_top_level_of_a_file_when_that_file_is_a_module_but_this_file_has_no_imports_or_exports_Consider_adding_an_empty_export_to_make_this_file_a_module))`
	`1211`	`+ c.addDiagnostic(createDiagnosticForNode(forInOrOfStatement.AwaitModifier, diagnostics.X_for_await_loops_are_only_allowed_at_the_top_level_of_a_file_when_that_file_is_a_module_but_this_file_has_no_imports_or_exports_Consider_adding_an_empty_export_to_make_this_file_a_module))`
`1212`	`1212`	`}`
`1213`	`1213`	`switch c.moduleKind {`
`1214`	`1214`	`case core.ModuleKindNode16, core.ModuleKindNode18, core.ModuleKindNode20, core.ModuleKindNodeNext:`
`1215`	`1215`	`sourceFileMetaData := c.program.GetSourceFileMetaData(sourceFile.Path())`
`1216`	`1216`	`if sourceFileMetaData.ImpliedNodeFormat == core.ModuleKindCommonJS {`
`1217`		`- c.diagnostics.Add(createDiagnosticForNode(forInOrOfStatement.AwaitModifier, diagnostics.The_current_file_is_a_CommonJS_module_and_cannot_use_await_at_the_top_level))`
	`1217`	`+ c.addDiagnostic(createDiagnosticForNode(forInOrOfStatement.AwaitModifier, diagnostics.The_current_file_is_a_CommonJS_module_and_cannot_use_await_at_the_top_level))`
`1218`	`1218`	`break`
`1219`	`1219`	`}`
`1220`	`1220`	`fallthrough`
`@@ -1227,7 +1227,7 @@ func (c Checker) checkGrammarForInOrForOfStatement(forInOrOfStatement ast.ForI`
`1227`	`1227`	`}`
`1228`	`1228`	`fallthrough`
`1229`	`1229`	`default:`
`1230`		`- c.diagnostics.Add(createDiagnosticForNode(forInOrOfStatement.AwaitModifier, diagnostics.Top_level_for_await_loops_are_only_allowed_when_the_module_option_is_set_to_es2022_esnext_system_node16_node18_node20_nodenext_or_preserve_and_the_target_option_is_set_to_es2017_or_higher))`
	`1230`	`+ c.addDiagnostic(createDiagnosticForNode(forInOrOfStatement.AwaitModifier, diagnostics.Top_level_for_await_loops_are_only_allowed_when_the_module_option_is_set_to_es2022_esnext_system_node16_node18_node20_nodenext_or_preserve_and_the_target_option_is_set_to_es2017_or_higher))`
`1231`	`1231`	`}`
`1232`	`1232`	`}`
`1233`	`1233`	`} else {`
`@@ -1240,7 +1240,7 @@ func (c Checker) checkGrammarForInOrForOfStatement(forInOrOfStatement ast.ForI`
`1240`	`1240`	`relatedInfo := createDiagnosticForNode(containingFunc, diagnostics.Did_you_mean_to_mark_this_function_as_async)`
`1241`	`1241`	`diagnostic.AddRelatedInfo(relatedInfo)`
`1242`	`1242`	`}`
`1243`		`- c.diagnostics.Add(diagnostic)`
	`1243`	`+ c.addDiagnostic(diagnostic)`
`1244`	`1244`	`return true`
`1245`	`1245`	`}`
`1246`	`1246`	`}`
`@@ -1702,7 +1702,7 @@ func (c Checker) checkGrammarAwaitOrAwaitUsing(node ast.Node) bool {`
`1702`	`1702`	`message = diagnostics.X_await_using_statements_are_only_allowed_at_the_top_level_of_a_file_when_that_file_is_a_module_but_this_file_has_no_imports_or_exports_Consider_adding_an_empty_export_to_make_this_file_a_module`
`1703`	`1703`	`}`
`1704`	`1704`	`diagnostic := ast.NewDiagnostic(sourceFile, span, message)`
`1705`		`- c.diagnostics.Add(diagnostic)`
	`1705`	`+ c.addDiagnostic(diagnostic)`
`1706`	`1706`	`hasError = true`
`1707`	`1707`	`}`
`1708`	`1708`	`switch c.moduleKind {`
`@@ -1715,7 +1715,7 @@ func (c Checker) checkGrammarAwaitOrAwaitUsing(node ast.Node) bool {`
`1715`	`1715`	`if !spanCalculated {`
`1716`	`1716`	`span = scanner.GetRangeOfTokenAtPosition(sourceFile, node.Pos())`
`1717`	`1717`	`}`
`1718`		`- c.diagnostics.Add(ast.NewDiagnostic(sourceFile, span, diagnostics.The_current_file_is_a_CommonJS_module_and_cannot_use_await_at_the_top_level))`
	`1718`	`+ c.addDiagnostic(ast.NewDiagnostic(sourceFile, span, diagnostics.The_current_file_is_a_CommonJS_module_and_cannot_use_await_at_the_top_level))`
`1719`	`1719`	`hasError = true`
`1720`	`1720`	`break`
`1721`	`1721`	`}`
`@@ -1738,7 +1738,7 @@ func (c Checker) checkGrammarAwaitOrAwaitUsing(node ast.Node) bool {`
`1738`	`1738`	`} else {`
`1739`	`1739`	`message = diagnostics.Top_level_await_using_statements_are_only_allowed_when_the_module_option_is_set_to_es2022_esnext_system_node16_node18_node20_nodenext_or_preserve_and_the_target_option_is_set_to_es2017_or_higher`
`1740`	`1740`	`}`
`1741`		`- c.diagnostics.Add(ast.NewDiagnostic(sourceFile, span, message))`
	`1741`	`+ c.addDiagnostic(ast.NewDiagnostic(sourceFile, span, message))`
`1742`	`1742`	`hasError = true`
`1743`	`1743`	`}`
`1744`	`1744`	`}`
`@@ -1758,7 +1758,7 @@ func (c Checker) checkGrammarAwaitOrAwaitUsing(node ast.Node) bool {`
`1758`	`1758`	`relatedInfo := NewDiagnosticForNode(container, diagnostics.Did_you_mean_to_mark_this_function_as_async)`
`1759`	`1759`	`diagnostic.AddRelatedInfo(relatedInfo)`
`1760`	`1760`	`}`
`1761`		`- c.diagnostics.Add(diagnostic)`
	`1761`	`+ c.addDiagnostic(diagnostic)`
`1762`	`1762`	`hasError = true`
`1763`	`1763`	`}`
`1764`	`1764`	`}`
Original file line number	Diff line number	Diff line change
`@@ -147,7 +147,7 @@ func (c Checker) checkJsxOpeningLikeElementOrOpeningFragment(node ast.Node) {`
`147`	`147`	`}`
`148`	`148`	`var diags []*ast.Diagnostic`
`149`	`149`	`if !c.checkTypeRelatedToEx(tagType, elementTypeConstraint, c.assignableRelation, tagName, diagnostics.Its_type_0_is_not_a_valid_JSX_element_type, &diags) {`
`150`		`- c.diagnostics.Add(ast.NewDiagnosticChain(diags[0], diagnostics.X_0_cannot_be_used_as_a_JSX_component, scanner.GetTextOfNode(tagName)))`
	`150`	`+ c.addDiagnostic(ast.NewDiagnosticChain(diags[0], diagnostics.X_0_cannot_be_used_as_a_JSX_component, scanner.GetTextOfNode(tagName)))`
`151`	`151`	`}`
`152`	`152`	`} else {`
`153`	`153`	`c.checkJsxReturnAssignableToAppropriateBound(c.getJsxReferenceKind(node), c.getReturnTypeOfSignature(sig), node)`
`@@ -189,7 +189,7 @@ func (c *Checker) checkJsxReturnAssignableToAppropriateBound(refKind JsxReferenc`
`189`	`189`	`c.checkTypeRelatedToEx(elemInstanceType, combined, c.assignableRelation, openingLikeElement.TagName(), diagnostics.Its_element_type_0_is_not_a_valid_JSX_element, &diags)`
`190`	`190`	`}`
`191`	`191`	`if len(diags) != 0 {`
`192`		`- c.diagnostics.Add(ast.NewDiagnosticChain(diags[0], diagnostics.X_0_cannot_be_used_as_a_JSX_component, scanner.GetTextOfNode(openingLikeElement.TagName())))`
	`192`	`+ c.addDiagnostic(ast.NewDiagnosticChain(diags[0], diagnostics.X_0_cannot_be_used_as_a_JSX_component, scanner.GetTextOfNode(openingLikeElement.TagName())))`
`193`	`193`	`}`
`194`	`194`	`}`
`195`	`195`
`@@ -554,7 +554,7 @@ func (c Checker) resolveJsxOpeningLikeElement(node ast.Node, candidatesOutArra`
`554`	`554`	`sourceFile := ast.GetSourceFileOfNode(node)`
`555`	`555`	`typeArgumentList := node.TypeArgumentList()`
`556`	`556`	`loc := core.NewTextRange(scanner.SkipTrivia(sourceFile.Text(), typeArgumentList.Loc.Pos()), typeArgumentList.Loc.End())`
`557`		`- c.diagnostics.Add(ast.NewDiagnostic(sourceFile, loc, diagnostics.Expected_0_type_arguments_but_got_1, 0, len(typeArguments)))`
	`557`	`+ c.addDiagnostic(ast.NewDiagnostic(sourceFile, loc, diagnostics.Expected_0_type_arguments_but_got_1, 0, len(typeArguments)))`
`558`	`558`	`}`
`559`	`559`	`return fakeSignature`
`560`	`560`	`}`
Original file line number	Diff line number	Diff line change
`@@ -418,7 +418,7 @@ func (c Checker) reportDiagnostic(diagnostic ast.Diagnostic, diagnosticOutput`
`418`	`418`	`if diagnosticOutput != nil {`
`419`	`419`	`diagnosticOutput = append(diagnosticOutput, diagnostic)`
`420`	`420`	`} else {`
`421`		`- c.diagnostics.Add(diagnostic)`
	`421`	`+ c.addDiagnostic(diagnostic)`
`422`	`422`	`}`
`423`	`423`	`}`
`424`	`424`	`}`