Use one cached nodebuilder for potentially circular internal ops, just like strada (#3833)

Author: weswigham

internal/checker/checker.go

@@ -884,6 +884,7 @@ type Checker struct {
 	reportedUnreachableNodes                    collections.Set[*ast.Node]
 	nonExistentProperties                       collections.Set[NonExistentPropertyKey]
 	deferredDiagnosticCallbacks                 []func()
+	typeToStringNodebuilder                     *NodeBuilder
 
 	mu     sync.Mutex
 	tracer *Tracer // Optional tracer for trace events and type recording (for --generateTrace)

internal/checker/nodebuilder.go

@@ -286,7 +286,11 @@ func NewNodeBuilderEx(ch *Checker, e *printer.EmitContext, idToSymbol map[*ast.I
 }
 
 func (c *Checker) getNodeBuilder() *NodeBuilder {
-	return c.getNodeBuilderEx(nil /*idToSymbol*/)
+	if c.typeToStringNodebuilder != nil {
+		return c.typeToStringNodebuilder
+	}
+	c.typeToStringNodebuilder = c.getNodeBuilderEx(nil /*idToSymbol*/)
+	return c.typeToStringNodebuilder
 }
 
 func (c *Checker) getNodeBuilderEx(idToSymbol map[*ast.IdentifierNode]*ast.Symbol) *NodeBuilder {

internal/checker/nodebuilderimpl.go

@@ -2990,7 +2990,7 @@ func (b *NodeBuilderImpl) visitAndTransformType(t *Type, transform func(b *NodeB
 	// of types allows us to catch circular references to instantiations of the same anonymous type
 
 	key := CompositeTypeCacheIdentity{typeId, b.ctx.flags, b.ctx.internalFlags}
-	if b.ctx.enclosingDeclaration != nil && b.links.Has(b.ctx.enclosingDeclaration) {
+	if b.ctx.maxExpansionDepth <= 0 && b.ctx.enclosingDeclaration != nil && b.links.Has(b.ctx.enclosingDeclaration) {
 		links := b.links.Get(b.ctx.enclosingDeclaration)
 		cachedResult, ok := links.serializedTypes[key]
 		if ok {

testdata/baselines/reference/compiler/noTypeToStringStackOverflow.errors.txt

@@ -0,0 +1,12 @@
+noTypeToStringStackOverflow.ts(3,7): error TS7023: 'f' implicitly has return type 'any' because it does not have a return type annotation and is referenced directly or indirectly in one of its return expressions.
+noTypeToStringStackOverflow.ts(3,20): error TS1360: Type 'number' does not satisfy the expected type '() => any'.
+
+
+==== noTypeToStringStackOverflow.ts (2 errors) ====
+    // https://github.com/microsoft/typescript-go/issues/3805
+    
+    const f = () => 42 satisfies typeof f;
+          ~
+!!! error TS7023: 'f' implicitly has return type 'any' because it does not have a return type annotation and is referenced directly or indirectly in one of its return expressions.
+                       ~~~~~~~~~
+!!! error TS1360: Type 'number' does not satisfy the expected type '() => any'.

testdata/baselines/reference/compiler/noTypeToStringStackOverflow.symbols

@@ -0,0 +1,9 @@
+//// [tests/cases/compiler/noTypeToStringStackOverflow.ts] ////
+
+=== noTypeToStringStackOverflow.ts ===
+// https://github.com/microsoft/typescript-go/issues/3805
+
+const f = () => 42 satisfies typeof f;
+>f : Symbol(f, Decl(noTypeToStringStackOverflow.ts, 2, 5))
+>f : Symbol(f, Decl(noTypeToStringStackOverflow.ts, 2, 5))
+

testdata/baselines/reference/compiler/noTypeToStringStackOverflow.types

@@ -0,0 +1,12 @@
+//// [tests/cases/compiler/noTypeToStringStackOverflow.ts] ////
+
+=== noTypeToStringStackOverflow.ts ===
+// https://github.com/microsoft/typescript-go/issues/3805
+
+const f = () => 42 satisfies typeof f;
+>f : () => any
+>() => 42 satisfies typeof f : () => any
+>42 satisfies typeof f : 42
+>42 : 42
+>f : () => any
+

testdata/tests/cases/compiler/noTypeToStringStackOverflow.ts

@@ -0,0 +1,5 @@
+// @noEmit: true
+
+// https://github.com/microsoft/typescript-go/issues/3805
+
+const f = () => 42 satisfies typeof f;