Reparse JSDoc annotations on get accessors (#3608)

Author: ahejlsberg

internal/fourslash/_scripts/failingTests.txt

@@ -209,7 +209,6 @@ TestGetJavaScriptQuickInfo4
 TestGetJavaScriptQuickInfo5
 TestGetJavaScriptQuickInfo6
 TestGetJavaScriptQuickInfo7
-TestGetJavaScriptQuickInfo8
 TestGetJavaScriptSyntacticDiagnostics24
 TestGetJSXOutliningSpans
 TestHoverOverComment

internal/parser/reparser.go

@@ -288,7 +288,7 @@ func (p *Parser) reparseHosted(tag *ast.Node, parent *ast.Node, jsDoc *ast.Node)
 				}
 			}
 		case ast.KindVariableDeclaration, ast.KindExportAssignment, ast.KindPropertyDeclaration, ast.KindPropertyAssignment,
-			ast.KindShorthandPropertyAssignment:
+			ast.KindShorthandPropertyAssignment, ast.KindGetAccessor:
 			if parent.Type() == nil && tag.TypeExpression() != nil {
 				parent.AsMutable().SetType(p.addDeepCloneReparse(tag.TypeExpression().Type()))
 				p.finishMutatedNode(parent)

testdata/baselines/reference/submodule/conformance/jsDeclarationsReusesExistingTypeAnnotations.js

@@ -201,13 +201,13 @@ declare class С1 {
 }
 declare class С2 {
     /** @type {string=} */
-    get p1(): undefined;
+    get p1(): string | undefined;
     /** @type {string | undefined} */
-    get p2(): undefined;
+    get p2(): string | undefined;
     /** @type {?string} */
-    get p3(): null;
+    get p3(): string | null;
     /** @type {string | null} */
-    get p4(): null;
+    get p4(): string | null;
 }
 declare class С3 {
     /** @type {string=} */

testdata/baselines/reference/submodule/conformance/jsDeclarationsReusesExistingTypeAnnotations.types

@@ -28,30 +28,30 @@ class С2 {
 
     /** @type {string=} */
     get p1() {
->p1 : undefined
+>p1 : string | undefined
 
         return undefined;
 >undefined : undefined
     }
 
     /** @type {string | undefined} */
     get p2() {
->p2 : undefined
+>p2 : string | undefined
 
         return undefined;
 >undefined : undefined
     }
 
     /** @type {?string} */
     get p3() {
->p3 : null
+>p3 : string | null
 
         return null;
     }
 
     /** @type {string | null} */
     get p4() {
->p4 : null
+>p4 : string | null
 
         return null;
     }

testdata/baselines/reference/submodule/conformance/jsDeclarationsReusesExistingTypeAnnotations.types.diff

@@ -1,46 +1,33 @@
 --- old.jsDeclarationsReusesExistingTypeAnnotations.js
 +++ new.jsDeclarationsReusesExistingTypeAnnotations.js
-@@= skipped -200, +200 lines =@@
- }
- declare class С2 {
-     /** @type {string=} */
--    get p1(): string | undefined;
-+    get p1(): undefined;
-     /** @type {string | undefined} */
--    get p2(): string | undefined;
-+    get p2(): undefined;
-     /** @type {?string} */
--    get p3(): string | null;
-+    get p3(): null;
-     /** @type {string | null} */
--    get p4(): string | null;
-+    get p4(): null;
+@@= skipped -209, +209 lines =@@
+     get p4(): string | null;
  }
  declare class С3 {
 -    /** @param {string=} value */
 -    set p1(value: string | undefined);
      /** @type {string=} */
      get p1(): string | undefined;
+-    /** @param {string | undefined} value */
+-    set p2(value: string | undefined);
 +    /** @param {string=} value */
 +    set p1(value?: string | undefined);
-+    /** @type {string | undefined} */
-+    get p2(): string | undefined;
-     /** @param {string | undefined} value */
-     set p2(value: string | undefined);
--    /** @type {string | undefined} */
--    get p2(): string | undefined;
-+    /** @type {?string} */
-+    get p3(): string | null;
-     /** @param {?string} value */
-     set p3(value: string | null);
--    /** @type {?string} */
--    get p3(): string | null;
-+    /** @type {string | null} */
-+    get p4(): string | null;
-     /** @param {string | null} value */
-     set p4(value: string | null);
--    /** @type {string | null} */
--    get p4(): string | null;
+     /** @type {string | undefined} */
+     get p2(): string | undefined;
+-    /** @param {?string} value */
+-    set p3(value: string | null);
++    /** @param {string | undefined} value */
++    set p2(value: string | undefined);
+     /** @type {?string} */
+     get p3(): string | null;
+-    /** @param {string | null} value */
+-    set p4(value: string | null);
++    /** @param {?string} value */
++    set p3(value: string | null);
+     /** @type {string | null} */
+     get p4(): string | null;
++    /** @param {string | null} value */
++    set p4(value: string | null);
  }
  declare class С4 {
      /** @param {string=} value */