fix(2047): Incomplete declaration emit of callback tag with no return tag (#2100)

Author: a-tarasyuk

internal/parser/reparser.go

@@ -132,7 +132,7 @@ func (p *Parser) reparseJSDocSignature(jsSignature *ast.Node, fun *ast.Node, jsD
 	case ast.KindConstructor:
 		signature = p.factory.NewConstructorDeclaration(clonedModifiers, nil, nil, nil, nil, nil)
 	case ast.KindJSDocCallbackTag:
-		signature = p.factory.NewFunctionTypeNode(nil, nil, nil)
+		signature = p.factory.NewFunctionTypeNode(nil, nil, p.factory.NewKeywordTypeNode(ast.KindAnyKeyword))
 	default:
 		panic("Unexpected kind " + fun.Kind.String())
 	}

testdata/baselines/reference/submodule/compiler/jsFileAlternativeUseOfOverloadTag.js

@@ -139,7 +139,7 @@ declare const example2: {
     constructor: () => void;
 };
 declare function evaluate(): any;
-type callback = (error: any, result: any) ;
+type callback = (error: any, result: any) => any;
 declare const example3: {
     /**
      * @overload evaluate(options = {}, [callback])
@@ -156,65 +156,3 @@ declare const example3: {
      */
     evaluate: (options: any, callback: any) => void;
 };
-
-
-//// [DtsFileErrors]
-
-
-dist/jsFileAlternativeUseOfOverloadTag.d.ts(34,43): error TS1005: '=>' expected.
-
-
-==== dist/jsFileAlternativeUseOfOverloadTag.d.ts (1 errors) ====
-    declare function Example1(value: any): any;
-    declare const example1: {
-        /**
-         * @overload Example1(value)
-         *   Creates Example1
-         *   @param value [String]
-         */
-        constructor: (value: any, options: any) => void;
-    };
-    declare function Example2(value: any, secretAccessKey: any, sessionToken: any): any;
-    declare function Example2(): any;
-    declare const example2: {
-        /**
-         * Example 2
-         *
-         * @overload Example2(value)
-         *   Creates Example2
-         *   @param value [String]
-         *   @param secretAccessKey [String]
-         *   @param sessionToken [String]
-         *   @example Creates with string value
-         *     const example = new Example('');
-         * @overload Example2(options)
-         *   Creates Example2
-         *   @option options value [String]
-         *   @example Creates with options object
-         *     const example = new Example2({
-         *       value: '',
-         *     });
-         */
-        constructor: () => void;
-    };
-    declare function evaluate(): any;
-    type callback = (error: any, result: any) ;
-                                              ~
-!!! error TS1005: '=>' expected.
-    declare const example3: {
-        /**
-         * @overload evaluate(options = {}, [callback])
-         *   Evaluate something
-         *   @note Something interesting
-         *   @param options [map]
-         *   @return [string] returns evaluation result
-         *   @return [null] returns nothing if callback provided
-         *   @callback callback function (error, result)
-         *     If callback is provided it will be called with evaluation result
-         *     @param error [Error]
-         *     @param result [String]
-         *   @see callback
-         */
-        evaluate: (options: any, callback: any) => void;
-    };
-    

testdata/baselines/reference/submodule/compiler/jsFileAlternativeUseOfOverloadTag.js.diff

@@ -82,7 +82,7 @@
 +    constructor: () => void;
 +};
 +declare function evaluate(): any;
-+type callback = (error: any, result: any) ;
++type callback = (error: any, result: any) => any;
 +declare const example3: {
      /**
       * @overload evaluate(options = {}, [callback])
@@ -99,66 +99,4 @@
 - */
 -type callback = (error: any, result: any) => any;
 +    evaluate: (options: any, callback: any) => void;
-+};
-+
-+
-+//// [DtsFileErrors]
-+
-+
-+dist/jsFileAlternativeUseOfOverloadTag.d.ts(34,43): error TS1005: '=>' expected.
-+
-+
-+==== dist/jsFileAlternativeUseOfOverloadTag.d.ts (1 errors) ====
-+    declare function Example1(value: any): any;
-+    declare const example1: {
-+        /**
-+         * @overload Example1(value)
-+         *   Creates Example1
-+         *   @param value [String]
-+         */
-+        constructor: (value: any, options: any) => void;
-+    };
-+    declare function Example2(value: any, secretAccessKey: any, sessionToken: any): any;
-+    declare function Example2(): any;
-+    declare const example2: {
-+        /**
-+         * Example 2
-+         *
-+         * @overload Example2(value)
-+         *   Creates Example2
-+         *   @param value [String]
-+         *   @param secretAccessKey [String]
-+         *   @param sessionToken [String]
-+         *   @example Creates with string value
-+         *     const example = new Example('');
-+         * @overload Example2(options)
-+         *   Creates Example2
-+         *   @option options value [String]
-+         *   @example Creates with options object
-+         *     const example = new Example2({
-+         *       value: '',
-+         *     });
-+         */
-+        constructor: () => void;
-+    };
-+    declare function evaluate(): any;
-+    type callback = (error: any, result: any) ;
-+                                              ~
-+!!! error TS1005: '=>' expected.
-+    declare const example3: {
-+        /**
-+         * @overload evaluate(options = {}, [callback])
-+         *   Evaluate something
-+         *   @note Something interesting
-+         *   @param options [map]
-+         *   @return [string] returns evaluation result
-+         *   @return [null] returns nothing if callback provided
-+         *   @callback callback function (error, result)
-+         *     If callback is provided it will be called with evaluation result
-+         *     @param error [Error]
-+         *     @param result [String]
-+         *   @see callback
-+         */
-+        evaluate: (options: any, callback: any) => void;
-+    };
-+    
++};

testdata/baselines/reference/submodule/conformance/jsDeclarationsFunctionPrototypeStatic.js

@@ -38,7 +38,7 @@ declare namespace MyClass {
 declare namespace MyClass {
     var staticProperty: number;
 }
-export type DoneCB = (failures: number) ;
+export type DoneCB = (failures: number) => any;
 /**
  * Callback to be invoked when test execution is complete.
  *

testdata/baselines/reference/submodule/conformance/jsDeclarationsFunctionPrototypeStatic.js.diff

@@ -18,7 +18,7 @@
 +declare namespace MyClass {
 +    var staticProperty: number;
 +}
-+export type DoneCB = (failures: number) ;
++export type DoneCB = (failures: number) => any;
  /**
   * Callback to be invoked when test execution is complete.
 - */

testdata/baselines/reference/submodule/conformance/jsDeclarationsParameterTagReusesInputNodeInEmit1.js

@@ -70,7 +70,7 @@ declare namespace BaseFactory {
 export = BaseFactory;
 //// [file.d.ts]
 type BaseFactory = import('./base');
-type BaseFactoryFactory = (factory: import('./base')) ;
+type BaseFactoryFactory = (factory: import('./base')) => any;
 /** @typedef {import('./base')} BaseFactory */
 /**
  * @callback BaseFactoryFactory

testdata/baselines/reference/submodule/conformance/jsDeclarationsParameterTagReusesInputNodeInEmit1.js.diff

@@ -25,7 +25,7 @@
 -    };
 -};
 +type BaseFactory = import('./base');
-+type BaseFactoryFactory = (factory: import('./base')) ;
++type BaseFactoryFactory = (factory: import('./base')) => any;
  /** @typedef {import('./base')} BaseFactory */
  /**
   * @callback BaseFactoryFactory

testdata/baselines/reference/submodule/conformance/templateInsideCallback.js

@@ -113,7 +113,7 @@ function flatMap(array, iterable = identity) {
 
 
 //// [templateInsideCallback.d.ts]
-type Call = () ;
+type Call = () => any;
 /**
  * @typedef Oops
  * @template T

testdata/baselines/reference/submodule/conformance/templateInsideCallback.js.diff

@@ -28,7 +28,7 @@
 - * @returns {T[]}
 - */
 -declare function flatMap(): any;
-+type Call = () ;
++type Call = () => any;
  /**
   * @typedef Oops
   * @template T