Skip to content

fix(2047): Incomplete declaration emit of callback tag with no return tag #2100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(2047): Incomplete declaration emit of callback tag with no return tag #2100

wants to merge 1 commit into from

Conversation

@a-tarasyuk
Copy link
Contributor

@a-tarasyuk a-tarasyuk commented Nov 15, 2025

Fixes #2047

jakebailey
jakebailey approved these changes Nov 15, 2025
View reviewed changes
Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this is acceptable for @callback without any return. void is probably bad. Perhaps this needs an error?

@jakebailey jakebailey requested a review from sandersn November 15, 2025 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakebailey jakebailey jakebailey approved these changes

@sandersn sandersn Awaiting requested review from sandersn

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incomplete declaration emit of callback tag with no return tag

2 participants

@a-tarasyuk @jakebailey