Skip to content

Commit dd3d9c7

Browse files
authored
Fix global diag test flake (#3875)
1 parent 1170944 commit dd3d9c7

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

internal/project/project_test.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -326,6 +326,10 @@ func TestPushDiagnostics(t *testing.T) {
326326
// Request semantic diagnostics to trigger checking, which triggers the global type resolvers.
327327
ls, err := session.GetLanguageService(projecttestutil.WithRequestID(context.Background()), lsproto.DocumentUri("file:///src/index.ts"))
328328
assert.NilError(t, err)
329+
// Drain background tasks from DidOpenFile (publishProgramDiagnostics, etc.)
330+
// before triggering global diagnostics, to avoid racing with publishGlobalDiagnostics.
331+
session.WaitForBackgroundTasks()
332+
329333
_, err = ls.ProvideDiagnostics(projecttestutil.WithRequestID(context.Background()), lsproto.DocumentUri("file:///src/index.ts"))
330334
assert.NilError(t, err)
331335
// Enqueue global diagnostics publishing (normally done by the LSP server after each request).

0 commit comments

Comments
 (0)