Merge main and use getRangeOfNode helper

Author: Copilot

.custom-gcl.yml

@@ -1,6 +1,6 @@
 # yaml-language-server: $schema=https://golangci-lint.run/jsonschema/custom-gcl.jsonschema.json
 
-version: v2.3.0
+version: v2.5.0
 
 destination: ./_tools
 

.dprint.jsonc

@@ -39,9 +39,8 @@
     },
     "exec": {
         "cwd": "${configDir}",
-        "cacheKey": "4",
         "commands": [
-            { "command": "go tool mvdan.cc/gofumpt -lang=go1.24", "exts": ["go"] }
+            { "command": "go tool mvdan.cc/gofumpt", "exts": ["go"], "cacheKeyFiles": ["go.mod"] }
         ]
     },
     "excludes": [
@@ -59,9 +58,9 @@
     // Note: if adding new languages, make sure settings.template.json is updated too.
     // Also, if updating typescript, update the one in package.json.
     "plugins": [
-        "https://plugins.dprint.dev/typescript-0.95.8.wasm",
+        "https://plugins.dprint.dev/typescript-0.95.11.wasm",
         "https://plugins.dprint.dev/json-0.20.0.wasm",
         "https://plugins.dprint.dev/g-plane/pretty_yaml-v0.5.1.wasm",
-        "https://plugins.dprint.dev/exec-0.5.1.json@492414e39dea4dccc07b4af796d2f4efdb89e84bae2bd4e1e924c0cc050855bf"
+        "https://plugins.dprint.dev/exec-0.6.0.json@a054130d458f124f9b5c91484833828950723a5af3f8ff2bd1523bd47b83b364"
     ]
 }

.github/ISSUE_TEMPLATE/03-vscode-editor-issue.yml

@@ -0,0 +1,48 @@
+name: 'VS Code Editor Issue'
+description: 'Issue using tsgo in VS Code'
+labels: 'Domain: Editor'
+assignees: []
+body:
+  - type: input
+    id: extension_version
+    attributes:
+      label: Extension Version
+      description: The version of the TypeScript (native preview) extension
+      placeholder: '0.20251016.x'
+    validations:
+      required: true
+  - type: input
+    id: vscode_version
+    attributes:
+      label: VS Code Version
+      description: The version of the VS Code you are using
+      placeholder: '1.105.x'
+    validations:
+      required: true
+  - type: input
+    id: os_version
+    attributes:
+      label: Operating system Version
+      description: Your operating system and version
+    validations:
+      required: true
+  - type: textarea
+    id: steps
+    attributes:
+      label: 'Steps to reproduce'
+      description: |
+        Information about how to reproduce the issue and expected behavior
+      value: |
+        1.
+        2.
+        3.
+    validations:
+      required: true
+  - type: textarea
+    id: bug_info
+    attributes:
+      label: 'Issue'
+      description: |
+        Information about the bug, such as expected vs actual behavior
+    validations:
+      required: true

.github/ISSUE_TEMPLATE/03-other.md renamed to .github/ISSUE_TEMPLATE/04-other.md

@@ -4,33 +4,135 @@ description: Setup Go
 inputs:
   go-version:
     description: Go version range to set up.
-    default: '>=1.24.0'
-  cache-name:
-    description: Name of scoped cache for this set up.
-    default: 'cache'
+    default: '>=1.25.0'
+  create:
+    description: Create the cache
+    default: 'false'
+  lint-cache:
+    description: Restore the golangci-lint cache
+    default: 'false'
 
 runs:
   using: composite
+
   steps:
     - name: Install Go
       id: install-go
-      uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0
+      uses: actions/setup-go@44694675825211faa026b3c33043df3e48a5fa00 # v6.0.0
       with:
         go-version: ${{ inputs.go-version }}
         cache: false
 
-    # There is more code downloaded and built than is covered by '**/go.sum',
-    # so give each job its own cache to try and not end up sharing the wrong
-    # cache between jobs, and hash the Herebyfile and golancgi-lint version.
+    # Avoid hardcoding the cache keys more than once.
+    - name: Get cache info
+      shell: bash
+      id: cache-info
+      env:
+        MODULES_KEY: go-modules-${{ runner.os }}-${{ steps.install-go.outputs.go-version }}-${{ hashFiles('**/go.sum', '**/.custom-gcl.yml') }}
+        LINT_KEY: golangci-lint-${{ runner.os }}-${{ steps.install-go.outputs.go-version }}-${{ hashFiles('**/go.sum', '**/.custom-gcl.yml') }}
+        BUILD_KEY: go-build-cache-${{ runner.os }}-${{ steps.install-go.outputs.go-version }}
+      run: |
+        echo "modules-key=$MODULES_KEY" >> $GITHUB_OUTPUT
+        echo "lint-key=$LINT_KEY" >> $GITHUB_OUTPUT
+        echo "build-key=$BUILD_KEY" >> $GITHUB_OUTPUT
+        echo "GOLANGCI_LINT_CACHE=$RUNNER_TEMP/golangci-lint-cache" >> $GITHUB_ENV
 
-    - name: Go cache
-      uses: actions/cache@5a3ec84eff668545956fd18022155c47e93e2684 # v4.2.3
+    - if: ${{ inputs.create != 'true' }}
+      name: Restore Go modules
+      uses: actions/cache/restore@0057852bfaa89a56745cba8c7296529d2fc39830 # v4.3.0
       with:
-        key: ts-setup-go-${{ runner.os }}-${{ steps.install-go.outputs.go-version }}-${{ hashFiles('**/go.sum', '**/Herebyfile.mjs', '**/.custom-gcl.yml') }}-${{ github.workflow }}-${{ inputs.cache-name }}
-        restore-keys: |
-          ts-setup-go-${{ runner.os }}-${{ steps.install-go.outputs.go-version }}-${{ hashFiles('**/go.sum', '**/Herebyfile.mjs', '**/.custom-gcl.yml') }}-${{ github.workflow }}-
+        key: ${{ steps.cache-info.outputs.modules-key }}
         path: |
           ~/go/pkg/mod
+
+    - if: ${{ inputs.create != 'true' }}
+      name: Restore Go build cache
+      uses: actions/cache/restore@0057852bfaa89a56745cba8c7296529d2fc39830 # v4.3.0
+      with:
+        key: unused-key-${{ github.run_id }}
+        restore-keys: ${{ steps.cache-info.outputs.build-key }}-
+        path: |
           ~/.cache/go-build
           ~/Library/Caches/go-build
           ~/AppData/Local/go-build
+
+    - if: ${{ inputs.create != 'true' && inputs.lint-cache == 'true' }}
+      name: Restore golangci-lint cache
+      uses: actions/cache/restore@0057852bfaa89a56745cba8c7296529d2fc39830 # v4.3.0
+      with:
+        key: unused-key-${{ github.run_id }}
+        restore-keys: ${{ steps.cache-info.outputs.lint-key }}-
+        path: ${{ env.GOLANGCI_LINT_CACHE }}
+
+    - name: Set mtimes
+      shell: bash
+      run: |
+        find . -type f ! -path ./.git/\*\* | go run github.com/slsyy/mtimehash/cmd/mtimehash@v1.0.0 || true
+        find . -type d ! -path ./.git/\*\* -exec touch -d '1970-01-01T00:00:01Z' {} + || true
+
+    # All steps below are only run if the cache is being created.
+
+    - if: ${{ inputs.create == 'true' }}
+      shell: bash
+      run: npm ci
+
+    - if: ${{ inputs.create == 'true' }}
+      shell: bash
+      run: |
+        go mod download
+        cd _tools
+        go mod download
+
+    - if: ${{ inputs.create == 'true' }}
+      shell: bash
+      run: npx hereby build
+
+    - if: ${{ inputs.create == 'true' }}
+      shell: bash
+      id: setup-go-test
+      run: npx hereby test
+
+    - if: ${{ failure() && inputs.create == 'true' && steps.setup-go-test.conclusion == 'failure' }}
+      shell: bash
+      run: git diff --diff-filter=AM --no-index ./testdata/baselines/reference ./testdata/baselines/local
+
+    - if: ${{ inputs.create == 'true' }}
+      shell: bash
+      run: npx hereby test --coverage
+
+    - if: ${{ inputs.create == 'true' }}
+      shell: bash
+      run: npx hereby lint
+
+    - if: ${{ inputs.create == 'true' }}
+      shell: bash
+      run: npx hereby lint --noembed
+
+    - if: ${{ inputs.create == 'true' }}
+      shell: bash
+      run: npx dprint check
+
+    - if: ${{ inputs.create == 'true' }}
+      name: Save Go modules
+      uses: actions/cache/save@0057852bfaa89a56745cba8c7296529d2fc39830 # v4.3.0
+      with:
+        key: ${{ steps.cache-info.outputs.modules-key }}
+        path: |
+          ~/go/pkg/mod
+
+    - if: ${{ inputs.create == 'true' }}
+      name: Save Go build cache
+      uses: actions/cache/save@0057852bfaa89a56745cba8c7296529d2fc39830 # v4.3.0
+      with:
+        key: ${{ steps.cache-info.outputs.build-key }}-${{ github.run_id }}
+        path: |
+          ~/.cache/go-build
+          ~/Library/Caches/go-build
+          ~/AppData/Local/go-build
+
+    - if: ${{ inputs.create == 'true' }}
+      name: Save golangci-lint cache
+      uses: actions/cache/save@0057852bfaa89a56745cba8c7296529d2fc39830 # v4.3.0
+      with:
+        key: ${{ steps.cache-info.outputs.lint-key }}-${{ github.run_id }}
+        path: ${{ env.GOLANGCI_LINT_CACHE }}

.github/ISSUE_TEMPLATE/04-copilot-pr-porting.md renamed to .github/ISSUE_TEMPLATE/05-copilot-pr-porting.md

@@ -0,0 +1,22 @@
+---
+name: Strada to Corsa Port Expert
+description: A Go and TypeScript expert who can easily figure out how to port PRs from one language to another
+---
+
+This repository is a port of `microsoft/TypeScript` from TypeScript to Go. Since the port began, the following pull request was applied to microsoft/TypeScript. An equivalent change now needs to be applied here. The user will give you a link to the PR and you will need to try to port it to this repo.
+
+Instructions
+- Use `curl` to fetch e.g. `https://api.github.com/repos/microsoft/typescript/pulls/59767` to view the merge commit SHA
+- Then use `curl` to fetch e.g. `https://github.com/microsoft/TypeScript/commit/bd3d70058c30253209199cc9dfeb85e72330d79b.patch` to download the diff patch
+- Use Playwright MCP if you have other information from github you need, since you won't have MCP access to the TypeScript repo
+- Apply the edits made in that PR to this codebase, translating them from TypeScript to Go.
+- The change may or may not be applicable. It may have already been ported. Do not make any significant changes outside the scope of the diff. If the change cannot be applied without significant out-of-scope changes, explain why and stop working.
+  - Tip: search for functions and identifiers from the diff to find the right location to apply edits. Some files in microsoft/TypeScript have been split into multiple.
+  - Tip: some changes have already been ported, like changes to diagnostic message text. Tests do not need to be ported as they are imported from the submodule.
+- Check that the code builds by running npx hereby build in the terminal.
+- Run tests. It is expected that tests will fail due to baseline changes.
+  - Run `npx hereby test` in a terminal. They should fail with messages about baseline changes.
+  - Tip: to run a single baseline test from the submodule, run go test ./internal/testrunner -run '^TestSubmodule/NAME_OF_TEST_FILE'
+  - Run npx hereby baseline-accept to adopt the baseline changes.
+  - Run git diff 'testdata/**/*.diff'. If your change is correct, these diff files will be reduced or completely deleted.
+- Iterate until you are satisfied with your change. Commit everything, including the baseline changes in testdata, and open a PR.

.github/actions/setup-go/action.yml

@@ -9,21 +9,34 @@ Most of our development takes place in the `internal` directory, and most behavi
 
 Most development on the codebase is in Go.
 Standard Go commands and practices apply, but we primarily use a tool called `hereby` to build, run tests, and other tasks.
-Run `npx hereby --list` to see all available commands.
+Run `npx hereby --tasks` to see all available commands.
 
 ```sh
-npx hereby build  # Build the project
+npx hereby build  # Build the tsgo binary (not required for tests)
 npx hereby test   # Run tests
 npx hereby format # Format the code
 npx hereby lint   # Run linters
 
 # To run a specific compiler test:
-go test -run='TestSubmodule/<test name>' ./internal/testrunner  # For submodule tests in _submodules/TypeScript
-go test -run='TestLocal/<test name>' ./internal/testrunner     # For local tests in testdata/tests/cases
+go test -run='TestSubmodule/<test name>' ./internal/testrunner  # For pre-existing "submodule" tests in _submodules/TypeScript
+go test -run='TestLocal/<test name>' ./internal/testrunner      # For new "local" tests created in testdata/tests/cases
+```
+
+Always make sure code is formatted, linted, and tested before sending a pull request.
+
+<critical>
+YOU MUST RUN THESE COMMANDS AT THE END OF YOUR SESSION!
+IF THESE COMMANDS FAIL, CI WILL FAIL, AND YOUR PR WILL BE REJECTED OUT OF HAND.
+FIXING ERRORS FROM THESE COMMANDS IS YOUR HIGHEST PRIORITY.
+ENSURE YOU DO THE RIGHT THINGS TO MAKE THEM PASS.
+```sh
+npx hereby build  # Build the project
+npx hereby test   # Run tests
+npx hereby lint   # Run linters
+npx hereby format # Format the code
 ```
+</critical>
 
-Always make sure code is formatted, linted, and tested before sending a pull request.
-
 ## Compiler Features, Fixes, and Tests
 
 When fixing a bug or implementing a new feature, at least one minimal test case should always be added in advance to verify the fix.
@@ -56,10 +69,10 @@ export interface Person {
 function greet(person) {
     console.log(`Hello, ${person.name}!`);
 }
-```
-
-**New compiler tests should always enable strict mode (`@strict: true`) unless the bug specifically involves non-strict mode behavior.**
-
+```
+
+**New compiler tests should always enable strict mode (`@strict: true`) unless the bug specifically involves non-strict mode behavior.**
+
 Tests don't always need the above `@option`s specified, but they are common to specify or modify.
 Tests can be run with multiple settings for a given option by using a comma-separated list (e.g. `@option: settingA,settingB`).
 `@filename` is only required when a test has multiple files, or when writing a test for a single JavaScript file (where `allowJs` or `checkJs` is enabled).
@@ -96,4 +109,4 @@ The TypeScript submodule serves as the reference implementation for behavior and
 # Other Instructions
 
 - Do not add or change existing dependencies unless asked to.
- 
+- Do not remove any debug assertions or panic calls. Existing assertions are never too strict or incorrect.