Avoid over-expanding recursive constraints in getBaseSignature (#3769)

Co-authored-by: Ryan Cavanaugh <RyanCavanaugh@users.noreply.github.com>

Author: Andarist

internal/checker/checker.go

@@ -19054,9 +19054,9 @@ func (c *Checker) getBaseSignature(signature *Signature) *Signature {
 	baseConstraints := core.Map(typeParameters, func(tp *Type) *Type {
 		return c.instantiateType(tp, baseConstraintMapper)
 	})
-	// Run N type params thru the immediate constraint mapper up to N times
-	// This way any noncircular interdependent type parameters are definitely resolved to their external dependencies
-	for range typeParameters {
+	// Run the immediate constraint mapper N-1 times so non-circular interdependent type parameters
+	// resolve to their external dependencies without adding an extra expansion step for self-recursive constraints.
+	for range len(typeParameters) - 1 {
 		baseConstraints = c.instantiateTypes(baseConstraints, baseConstraintMapper)
 	}
 	// and then apply a type eraser to remove any remaining circularly dependent type parameters

testdata/baselines/reference/submodule/conformance/genericFunctionParameters.js

@@ -29,7 +29,7 @@ declare function f2<T>(cb: <S extends number>(x: S) => T): T;
 declare function f3<T>(cb: <S extends Array<S>>(x: S) => T): T;
 declare let x1: unknown;
 declare let x2: number;
-declare let x3: any[][];
+declare let x3: any[];
 declare const s: <R>(go: <S>(ops: {
     init(): S;
 }) => R) => R;

testdata/baselines/reference/submodule/conformance/genericFunctionParameters.types

@@ -33,8 +33,8 @@ let x2 = f2(x => x);  // number
 >x : S
 
 let x3 = f3(x => x);  // Array<any>
->x3 : any[][]
->f3(x => x) : any[][]
+>x3 : any[]
+>f3(x => x) : any[]
 >f3 : <T>(cb: <S extends Array<S>>(x: S) => T) => T
 >x => x : <S extends S[]>(x: S) => S
 >x : S

testdata/baselines/reference/submodule/conformance/genericFunctionParameters.types.diff

@@ -208,10 +208,6 @@ conformance/jsDeclarationsModuleReferenceHasEmit(target=es2015).js.diff
 ## https://github.com/microsoft/typescript-go/issues/3563
 conformance/definiteAssignmentAssertionsWithObjectShortHand.js.diff
 
-# Generic function parameter inference change
-## https://github.com/microsoft/typescript-go/issues/3564
-conformance/genericFunctionParameters.js.diff
-
 # Late-bound computed property [prop] preserved instead of resolved to plain prop
 ## https://github.com/microsoft/typescript-go/issues/3566
 compiler/lateBoundAssignmentCandidateJS2.js.diff