Fix panic for rest properties in catch binding when targeting ES2017 (#3927)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: jakebailey <5341706+jakebailey@users.noreply.github.com>

Author: Copilot

internal/transformers/estransforms/objectrestspread.go

@@ -387,7 +387,7 @@ func (ch *objectRestSpreadTransformer) visitCatchClause(node *ast.CatchClause) *
 		block := ch.Visitor().VisitNode(node.Block)
 		if visitedBindings != nil {
 			var decls []*ast.Node
-			if visitedBindings.Kind&ast.KindSyntaxList != 0 {
+			if visitedBindings.Kind == ast.KindSyntaxList {
 				decls = visitedBindings.AsSyntaxList().Children
 			} else {
 				decls = []*ast.Node{visitedBindings}

testdata/baselines/reference/compiler/catchClauseRestProperties.errors.txt

@@ -0,0 +1,12 @@
+catchClauseRestProperties.ts(3,15): error TS2700: Rest types may only be created from object types.
+
+
+==== catchClauseRestProperties.ts (1 errors) ====
+    try {
+      // ...
+    } catch ({ ...rest }) {
+                  ~~~~
+!!! error TS2700: Rest types may only be created from object types.
+      // ...
+    }
+    

testdata/baselines/reference/compiler/catchClauseRestProperties.js

@@ -0,0 +1,30 @@
+//// [tests/cases/compiler/catchClauseRestProperties.ts] ////
+
+//// [catchClauseRestProperties.ts]
+try {
+  // ...
+} catch ({ ...rest }) {
+  // ...
+}
+
+
+//// [catchClauseRestProperties.js]
+"use strict";
+var __rest = (this && this.__rest) || function (s, e) {
+    var t = {};
+    for (var p in s) if (Object.prototype.hasOwnProperty.call(s, p) && e.indexOf(p) < 0)
+        t[p] = s[p];
+    if (s != null && typeof Object.getOwnPropertySymbols === "function")
+        for (var i = 0, p = Object.getOwnPropertySymbols(s); i < p.length; i++) {
+            if (e.indexOf(p[i]) < 0 && Object.prototype.propertyIsEnumerable.call(s, p[i]))
+                t[p[i]] = s[p[i]];
+        }
+    return t;
+};
+try {
+    // ...
+}
+catch (_a) {
+    var rest = __rest(_a, []);
+    // ...
+}

testdata/baselines/reference/compiler/catchClauseRestProperties.symbols

@@ -0,0 +1,11 @@
+//// [tests/cases/compiler/catchClauseRestProperties.ts] ////
+
+=== catchClauseRestProperties.ts ===
+try {
+  // ...
+} catch ({ ...rest }) {
+>rest : Symbol(rest, Decl(catchClauseRestProperties.ts, 2, 10))
+
+  // ...
+}
+

testdata/baselines/reference/compiler/catchClauseRestProperties.types

@@ -0,0 +1,11 @@
+//// [tests/cases/compiler/catchClauseRestProperties.ts] ////
+
+=== catchClauseRestProperties.ts ===
+try {
+  // ...
+} catch ({ ...rest }) {
+>rest : any
+
+  // ...
+}
+

testdata/tests/cases/compiler/catchClauseRestProperties.ts

@@ -0,0 +1,7 @@
+// @target: es2017
+
+try {
+  // ...
+} catch ({ ...rest }) {
+  // ...
+}