Skip to content

nodeModulesExportsSourceTs.ts is unstable in concurrent emit #2136

@jakebailey

Description

@jakebailey

https://github.com/microsoft/typescript-go/actions/runs/19548755476/job/55974335183?pr=2135

--- FAIL: TestSubmodule (6.21s)
    --- FAIL: TestSubmodule/nodeModulesExportsSourceTs.ts_module=nodenext (0.09s)
        --- FAIL: TestSubmodule/nodeModulesExportsSourceTs.ts_module=nodenext/output (0.03s)
            baseline.go:206: the baseline file /mnt/vss/_work/typescript-go/typescript-go/testdata/baselines/reference/submodule/conformance/nodeModulesExportsSourceTs(module=nodenext).js has changed. (Run `hereby baseline-accept` if the new baseline is correct.)
            baseline.go:206: the baseline file /mnt/vss/_work/typescript-go/typescript-go/testdata/baselines/reference/submodule/conformance/nodeModulesExportsSourceTs(module=nodenext).js.diff has changed. (Run `hereby baseline-accept` if the new baseline is correct.)
FAIL
FAIL	github.com/microsoft/typescript-go/internal/testrunner	106.023s
diff --git a/testdata/baselines/reference/submodule/conformance/nodeModulesExportsSourceTs(module=nodenext).js b/testdata/baselines/reference/submodule/conformance/nodeModulesExportsSourceTs(module=nodenext).js
index be568de7..72a2a207 100644
--- a/testdata/baselines/reference/submodule/conformance/nodeModulesExportsSourceTs(module=nodenext).js
+++ b/testdata/baselines/reference/submodule/conformance/nodeModulesExportsSourceTs(module=nodenext).js
@@ -27,8 +27,6 @@ export const x: () => Thing = null as any;
     "exports": "./index.ts"
 }
 
-//// [other.js]
-export const x = null;
 //// [index.js]
 // esm format file
 export { x } from "./other.js";
@@ -36,11 +34,19 @@ export { x } from "./other.js";
 export const a = (await import("inner")).x();
 
 
-//// [other.d.ts]
-export interface Thing {
-}
-export declare const x: () => Thing;
 //// [index.d.ts]
 export { x } from "./other.js";
 //// [index.d.ts]
 export declare const a: any;
+
+
+!!!! File node_modules/inner/other.d.ts missing from original emit, but present in noCheck emit
+//// [other.d.ts]
+export interface Thing {
+}
+export declare const x: () => Thing;
+
+
+!!!! File node_modules/inner/other.js missing from original emit, but present in noCheck emit
+//// [other.js]
+export const x = null;
diff --git a/testdata/baselines/reference/submodule/conformance/nodeModulesExportsSourceTs(module=nodenext).js.diff b/testdata/baselines/reference/submodule/conformance/nodeModulesExportsSourceTs(module=nodenext).js.diff
index a122a5bc..f7a85e93 100644
--- a/testdata/baselines/reference/submodule/conformance/nodeModulesExportsSourceTs(module=nodenext).js.diff
+++ b/testdata/baselines/reference/submodule/conformance/nodeModulesExportsSourceTs(module=nodenext).js.diff
@@ -1,8 +1,33 @@
 --- old.nodeModulesExportsSourceTs(module=nodenext).js
 +++ new.nodeModulesExportsSourceTs(module=nodenext).js
-@@= skipped -41, +41 lines =@@
- export declare const x: () => Thing;
- //// [index.d.ts]
+@@= skipped -26, +26 lines =@@
+     "exports": "./index.ts"
+ }
+
+-//// [other.js]
+-export const x = null;
+ //// [index.js]
+ // esm format file
  export { x } from "./other.js";
+@@= skipped -9, +7 lines =@@
+ export const a = (await import("inner")).x();
+
+
++//// [index.d.ts]
++export { x } from "./other.js";
 +//// [index.d.ts]
-+export declare const a: any;
\ No newline at end of file
++export declare const a: any;
++
++
++!!!! File node_modules/inner/other.d.ts missing from original emit, but present in noCheck emit
+ //// [other.d.ts]
+ export interface Thing {
+ }
+ export declare const x: () => Thing;
+-//// [index.d.ts]
+-export { x } from "./other.js";
++
++
++!!!! File node_modules/inner/other.js missing from original emit, but present in noCheck emit
++//// [other.js]
++export const x = null;

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions