Forbid platform specific package uses in agnostic files #1911
+42
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a linter rule to prevent accidental usage of Go's standard path and path/filepath packages, enforcing the use of the internal tspath package instead. This helps external contributors avoid compatibility issues since the codebase uses custom path handling.
- Enables the
forbidigolinter to detect and flag usage of standard path libraries - Configures exemptions for test files, tools, and specific internal packages where standard path usage is acceptable
- Adds a lint suppression comment to one existing legitimate use case in
extension.go
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .golangci.yml | Adds forbidigo linter with pattern rules to forbid path/filepath packages and defines exemption paths for tests and tools |
| internal/tspath/extension.go | Adds nolint comment to exempt legitimate filepath.Ext usage |
jakebailey
changed the title
sheetalkamat
approved these changes
Oct 20, 2025
jakebailey
commented
Oct 20, 2025
Comment on lines
+57
to
+58
| cmd := exec.Command("npm", args...) | ||
| cmd.Dir = cwd |
There was a problem hiding this comment.
A bit of a hack but I prefer this greatly to there being any chance that tests run npm install.
sheetalkamat
approved these changes
Oct 20, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly for external PRs which don't realize that our paths are usually incompatible with the stdlib packages (especially
filepath) outside certain circumstances.Same goes for
os,runtime.GOOS.