Respect client capabilities for diagnostics #1980
Merged
+38
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for respecting client diagnostic capabilities in the LSP server. The changes ensure that diagnostic-related information (related diagnostics, tags for unnecessary/deprecated code) is only sent to clients that explicitly support these features, improving LSP protocol compliance.
- Extracts diagnostic client capabilities from initialization parameters and passes them through the diagnostic pipeline
- Conditionally includes related information and diagnostic tags based on client capabilities
- Updates test infrastructure to set default diagnostic capabilities for fourslash tests
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/lsp/server.go | Extracts diagnostic client capabilities from initialization params and passes them to ProvideDiagnostics |
| internal/ls/diagnostics.go | Implements capability-aware diagnostic conversion that conditionally includes related information and tags based on client support |
| internal/fourslash/fourslash.go | Adds default diagnostic capabilities for fourslash tests to maintain existing test behavior |
navya9singh
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't respecting the client caps for diagnostic features, so were sending data we shouldn't when the client hasn't asked for it.