Don't add export modifier to JSTypeAliasDeclaration from @callback
#2063
+125
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahejlsberg
requested review from
Copilot and
jakebailey
and removed request for
Copilot
Copilot finished reviewing on behalf of
ahejlsberg
November 11, 2025 21:14
jakebailey
approved these changes
Nov 11, 2025
Member
There was a problem hiding this comment.
This seems correct, but doesn't seem to fix everything that my fix caught for the external module indicator, so I guess there's more work on that end (or my change was correct, which I think it is in theory...)
Checked by applying #2062 on top of this PR and looking at the new diffs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2048.