Store processing diagnostics on task instead of includeProcessor during file loading #2224
+17
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Processing diagnostics are now accumulated on tasks during file loading rather than directly added to
includeProcessor. TheincludeProcessoris created locally ingetProcessedFiles()where task diagnostics are consolidated.Changes
resolveTypeReferenceDirectives(): Append unresolved reference diagnostics totask.processingDiagnosticsinstead of callingincludeProcessor.addProcessingDiagnostic()parseTask.load(): Append lib reference diagnostics totask.processingDiagnosticsinstead of callingincludeProcessor.addProcessingDiagnostic()fileLoader: RemoveincludeProcessorfieldgetProcessedFiles(): Create localincludeProcessorvariable and pass it toaddIncludeReason()instead of accessing vialoaderThis maintains task-level diagnostic ownership during parsing and consolidates them only when assembling the final
processedFilesresult.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.