feat(http-client-csharp): support @flattenProperty
#3477
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is a port of Azure/autorest.csharp#4688 with some additional changes due to different code base: - add `FlattenedNames` to `InputModelProperty` - add `TryReadStringArray` to `Utf8JsonReaderExtensions`
archerzz
requested review from
allenjzhang,
bterlson,
markcowl and
timotheeguerin
as code owners
microsoft-github-policy-service
bot
added
the
emitter:client:csharp
chunyu3
reviewed
May 30, 2024
| public class InputModelProperty | ||
| { | ||
| public InputModelProperty(string name, string serializedName, string description, InputType type, bool isRequired, bool isReadOnly, bool isDiscriminator) | ||
| public InputModelProperty(string name, string serializedName, string description, InputType type, bool isRequired, bool isReadOnly, bool isDiscriminator, IReadOnlyList<string>? flattenedNames = null) |
Contributor
There was a problem hiding this comment.
Do we need flatten feature in non-branded SDK?
Member
Author
|
This PR has been covered in #3503 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a port of Azure/autorest.csharp#4688 with some additional changes due to different code base:
FlattenedNamestoInputModelPropertyTryReadStringArraytoUtf8JsonReaderExtensions