Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 25, 2025

PR #9082 switched to sparse checkout but omitted sdk/core/Azure.Core/src/Shared, causing build failures when Azure test projects reference shared source files like TrimmingAttribute.cs, RawRequestUriBuilder.cs, etc.

Changes

  • Added sdk/core/Azure.Core/src/Shared to sparse checkout pattern in Submit-AzureSdkForNetPr.ps1
git sparse-checkout set eng/packages/http-client-csharp eng sdk/core/Azure.Core/src/Shared
Original prompt

This section details on the original issue you should resolve

<issue_title>Build is now failing in the Update PR</issue_title>
<issue_description>#9082 updated to use sparse checkout but we are missing the Azure.Core shared source files:

CSC : error CS2001: Source file '/tmp/azure-sdk-for-net-20251125-171710/eng//../sdk/core/Azure.Core/src/Shared/TrimmingAttribute.cs' could not be found. [/tmp/azure-sdk-for-net-20251125-171710/eng/packages/http-client-csharp/generator/TestProjects/Spector/http/azure/example/basic/src/Specs.Azure.Example.Basic.csproj::TargetFramework=net8.0]
CSC : error CS2001: Source file '/tmp/azure-sdk-for-net-20251125-171710/eng//../sdk/core/Azure.Core/src/Shared/RawRequestUriBuilder.cs' could not be found. [/tmp/azure-sdk-for-net-20251125-171710/eng/packages/http-client-csharp/generator/TestProjects/Spector/http/azure/client-generator-core/api-version/header/src/Specs.Azure.ClientGenerator.Core.ApiVersion.Header.csproj::TargetFramework=net8.0]
CSC : error CS2001: Source file '/tmp/azure-sdk-for-net-20251125-171710/eng//../sdk/core/Azure.Core/src/Shared/TypeFormatters.cs' could not be found. [/tmp/azure-sdk-for-net-20251125-171710/eng/packages/http-client-csharp/generator/TestProjects/Spector/http/azure/client-generator-core/api-version/header/src/Specs.Azure.ClientGenerator.Core.ApiVersion.Header.csproj::TargetFramework=net8.0]
CSC : error CS2001: Source file '/tmp/azure-sdk-for-net-20251125-171710/eng//../sdk/core/Azure.Core/src/Shared/RequestHeaderExtensions.cs' could not be found. [/tmp/azure-sdk-for-net-20251125-171710/eng/packages/http-client-csharp/generator/TestProjects/Spector/http/azure/client-generator-core/api-version/header/src/Specs.Azure.ClientGenerator.Core.ApiVersion.Header.csproj::TargetFramework=net8.0]
CSC : error CS2001: Source file '/tmp/azure-sdk-for-net-20251125-171710/eng//../sdk/core/Azure.Core/src/Shared/AppContextSwitchHelper.cs' could not be found. [/tmp/azure-sdk-for-net-20251125-171710/eng/packages/http-client-csharp/generator/TestProjects/Spector/http/azure/client-generator-core/api-version/header/src/Specs.Azure.ClientGenerator.Core.ApiVersion.Header.csproj::TargetFramework=net8.0]
CSC : error CS2001: Source file '/tmp/azure-sdk-for-net-20251125-171710/eng//../sdk/core/Azure.Core/src/Shared/ClientDiagnostics.cs' could not be found. [/tmp/azure-sdk-for-net-20251125-171710/eng/packages/http-client-csharp/generator/TestProjects/Spector/http/azure/client-generator-core/api-version/header/src/Specs.Azure.ClientGenerator.Core.ApiVersion.Header.csproj::TargetFramework=net8.0]
CSC : error CS2001: Source file '/tmp/azure-sdk-for-net-20251125-171710/eng//../sdk/core/Azure.Core/src/Shared/DiagnosticScopeFactory.cs' could not be found. [/tmp/azure-sdk-for-net-20251125-171710/eng/packages/http-client-csharp/generator/TestProjects/Spector/http/azure/client-generator-core/api-version/header/src/Specs.Azure.ClientGenerator.Core.ApiVersion.Header.csproj::TargetFramework=net8.0]
CSC : error CS2001: Source file '/tmp/azure-sdk-for-net-20251125-171710/eng//../sdk/core/Azure.Core/src/Shared/DiagnosticScope.cs' could not be found. [/tmp/azure-</issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix build failure due to missing Azure.Core source files Fix sparse checkout to include Azure.Core shared source files Nov 25, 2025
Copilot finished work on behalf of JoshLove-msft November 25, 2025 17:28
Copilot AI requested a review from JoshLove-msft November 25, 2025 17:28
@JoshLove-msft JoshLove-msft marked this pull request as ready for review November 25, 2025 17:29
@microsoft-github-policy-service microsoft-github-policy-service bot added the emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp label Nov 25, 2025
@github-actions
Copy link
Contributor

No changes needing a change description found.

@JoshLove-msft JoshLove-msft added this pull request to the merge queue Nov 25, 2025
Merged via the queue into main with commit 036d573 Nov 25, 2025
22 checks passed
@JoshLove-msft JoshLove-msft deleted the copilot/fix-missing-azure-core-files branch November 25, 2025 18:43
github-merge-queue bot pushed a commit that referenced this pull request Nov 25, 2025
PR #9092 added `sdk/core/Azure.Core/src/Shared` to sparse checkout but
missed `sdk/core/Azure.Core.TestFramework/src` which contains
`ProcessTracker.cs` referenced by `TestProjects.Spector.Tests.csproj`.

### Changes
- Added `sdk/core/Azure.Core.TestFramework/src` to sparse checkout
patterns in `Submit-AzureSdkForNetPr.ps1`

```powershell
git sparse-checkout set eng/packages/http-client-csharp eng sdk/core/Azure.Core/src/Shared sdk/core/Azure.Core.TestFramework/src
```

<!-- START COPILOT CODING AGENT SUFFIX -->



<details>

<summary>Original prompt</summary>

> 
> ----
> 
> *This section details on the original issue you should resolve*
> 
> <issue_title>Missing ProcessTracker shared source file</issue_title>
> <issue_description>#9092 we
are still missing
https://github.com/Azure/azure-sdk-for-net/blob/main/eng/packages/http-client-csharp/generator/TestProjects/Spector.Tests/TestProjects.Spector.Tests.csproj#L126
> 
> We need to checkout this file as well.</issue_description>
> 
> ## Comments on the Issue (you are @copilot in this section)
> 
> <comments>
> </comments>
> 


</details>

- Fixes #9096

<!-- START COPILOT CODING AGENT TIPS -->
---

✨ Let Copilot coding agent [set things up for
you](https://github.com/microsoft/typespec/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot)
— coding agent works faster and does higher quality work when set up for
your repo.

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build is now failing in the Update PR

3 participants