-
Notifications
You must be signed in to change notification settings - Fork 321
Fix sparse checkout to include Azure.Core shared source files #9092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix build failure due to missing Azure.Core source files
Fix sparse checkout to include Azure.Core shared source files
Nov 25, 2025
Copilot finished work on behalf of
JoshLove-msft
November 25, 2025 17:28
packages/http-client-csharp/eng/scripts/Submit-AzureSdkForNetPr.ps1
Outdated
Show resolved
Hide resolved
Contributor
|
No changes needing a change description found. |
jsquire
approved these changes
Nov 25, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 25, 2025
PR #9092 added `sdk/core/Azure.Core/src/Shared` to sparse checkout but missed `sdk/core/Azure.Core.TestFramework/src` which contains `ProcessTracker.cs` referenced by `TestProjects.Spector.Tests.csproj`. ### Changes - Added `sdk/core/Azure.Core.TestFramework/src` to sparse checkout patterns in `Submit-AzureSdkForNetPr.ps1` ```powershell git sparse-checkout set eng/packages/http-client-csharp eng sdk/core/Azure.Core/src/Shared sdk/core/Azure.Core.TestFramework/src ``` <!-- START COPILOT CODING AGENT SUFFIX --> <details> <summary>Original prompt</summary> > > ---- > > *This section details on the original issue you should resolve* > > <issue_title>Missing ProcessTracker shared source file</issue_title> > <issue_description>#9092 we are still missing https://github.com/Azure/azure-sdk-for-net/blob/main/eng/packages/http-client-csharp/generator/TestProjects/Spector.Tests/TestProjects.Spector.Tests.csproj#L126 > > We need to checkout this file as well.</issue_description> > > ## Comments on the Issue (you are @copilot in this section) > > <comments> > </comments> > </details> - Fixes #9096 <!-- START COPILOT CODING AGENT TIPS --> --- ✨ Let Copilot coding agent [set things up for you](https://github.com/microsoft/typespec/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #9082 switched to sparse checkout but omitted
sdk/core/Azure.Core/src/Shared, causing build failures when Azure test projects reference shared source files likeTrimmingAttribute.cs,RawRequestUriBuilder.cs, etc.Changes
sdk/core/Azure.Core/src/Sharedto sparse checkout pattern inSubmit-AzureSdkForNetPr.ps1Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.