Skip to content

Conversation

dbaeumer
Copy link
Member

@dbaeumer dbaeumer commented Oct 7, 2025

No description provided.

@Copilot Copilot AI review requested due to automatic review settings October 7, 2025 12:38
@dbaeumer dbaeumer enabled auto-merge October 7, 2025 12:38
@dbaeumer dbaeumer self-assigned this Oct 7, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR excludes completions core test files from the worker TypeScript compilation configuration to prevent test code from being included in the worker bundle.

"src/**/*.d.ts"
],
"exclude": ["src/**/test/**", "src/**/fixtures/**"]
"exclude": ["src/**/test/**", "src/**/fixtures/**", "src/extension/completions-core/**/*.test.ts"]
Copy link

Copilot AI Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The specific exclusion for 'src/extension/completions-core//*.test.ts' is redundant since it's already covered by the more general 'src//test/**' pattern. The existing pattern should exclude all test files including those in completions-core.

Suggested change
"exclude": ["src/**/test/**", "src/**/fixtures/**", "src/extension/completions-core/**/*.test.ts"]
"exclude": ["src/**/test/**", "src/**/fixtures/**"]

Copilot uses AI. Check for mistakes.

@vs-code-engineering vs-code-engineering bot added this to the October 2025 milestone Oct 7, 2025
@dbaeumer dbaeumer added this pull request to the merge queue Oct 7, 2025
Merged via the queue into main with commit 46fc032 Oct 7, 2025
16 checks passed
@dbaeumer dbaeumer deleted the dbaeumer/purring-puma-violet branch October 7, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants